Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[openwebnet] Thermo: Fixed handling of mode=AUTO for bus_thermo_zone #16534

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

mvalla
Copy link
Contributor

@mvalla mvalla commented Mar 17, 2024

This PR fixes handling of AUTO mode for bus_thermo_zone things in systems with 4 or 99-zones Thermo Central Units.
With this fix it will be possible to set a zone to MANUAL and back to AUTO so that it will be set back to the current programming of the central unit.

Fixes #13754

mvalla added 2 commits March 17, 2024 21:52
Signed-off-by: Massimo Valla <mvcode00@gmail.com>
Fixes openhab#13754

Signed-off-by: Massimo Valla <mvcode00@gmail.com>
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo added the bug An unexpected problem or unintended behavior of an add-on label Mar 18, 2024
@lolodomo lolodomo merged commit 26fd8c6 into openhab:main Mar 18, 2024
3 checks passed
@lolodomo lolodomo added this to the 4.2 milestone Mar 18, 2024
magx2 pushed a commit to magx2/openhab2-addons that referenced this pull request Mar 24, 2024
…penhab#16534)

* [openwebnet] improved Thermo mode/weekly/scenario channels descriptions
* [openwebnet] Fixed handling of mode=AUTO for bus_thermo_zone
Fixes openhab#13754

---------

Signed-off-by: Massimo Valla <mvcode00@gmail.com>
@mvalla mvalla deleted the openwebnet-zone-auto-fix branch April 14, 2024 20:33
LeeC77 pushed a commit to LeeC77/openhab-addons that referenced this pull request May 25, 2024
…penhab#16534)

* [openwebnet] improved Thermo mode/weekly/scenario channels descriptions
* [openwebnet] Fixed handling of mode=AUTO for bus_thermo_zone
Fixes openhab#13754

---------

Signed-off-by: Massimo Valla <mvcode00@gmail.com>
Signed-off-by: LeeC77 <lee.charlton00@gmail.com>
pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 29, 2024
…penhab#16534)

* [openwebnet] improved Thermo mode/weekly/scenario channels descriptions
* [openwebnet] Fixed handling of mode=AUTO for bus_thermo_zone
Fixes openhab#13754

---------

Signed-off-by: Massimo Valla <mvcode00@gmail.com>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
…penhab#16534)

* [openwebnet] improved Thermo mode/weekly/scenario channels descriptions
* [openwebnet] Fixed handling of mode=AUTO for bus_thermo_zone
Fixes openhab#13754

---------

Signed-off-by: Massimo Valla <mvcode00@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[openwebnet] Thermo: add support for AUTO/NORMAL mode to bus_thermo_zone
2 participants