[intesis] Session Handling improved #16555
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have changed the login process so that the binding now only logs in at the beginning and logs out at the end of the lifetime. If a request fails due to a missing login or an invalid session ID, a new login attempt is made. This ensures that - Several requests can be sent in direct succession (if I switch the air conditioning from cooling to heating, I also want to change the slats at the same time) - Less traffic is generated as there is not a constant logout and login again - Ideally, the login credentials should only be visible once at startup Last change: login and logout is now running asynchronously in a scheduled task (#16476). Signed-off-by: Christoph <fd0cwp@gmx.de>
jlaur
requested changes
Mar 21, 2024
| String contentString = "{\"command\":\"logout\",\"data\":{\"sessionID\":\"" + sessionId + "\"}}"; | ||
| logger.trace("logout() - session ID: {}", sessionId); |
There was a problem hiding this comment.
Last thing - if sessionId.isEmpty() it will not make sense to try to log out.
jlaur
added
bug
I have changed the login process so that the binding now only logs in at the beginning and logs out at the end of the lifetime. If a request fails due to a missing login or an invalid session ID, a new login attempt is made. This ensures that - Several requests can be sent in direct succession (if I switch the air conditioning from cooling to heating, I also want to change the slats at the same time) - Less traffic is generated as there is not a constant logout and login again - Ideally, the login credentials should only be visible once at startup This change fixes #15502. Signed-off-by: Christoph fd0cwp@gmx.de
|
I don't get it with fixing PR change requests. :-( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have changed the login process so that the binding now only logs in at the beginning and logs out at the end of the lifetime. If a request fails due to a missing login or an invalid session ID, a new login attempt is made.
This ensures that
Last change: login and logout is now running asynchronously in a scheduled task (#16476).
This change fixes #15502.
Signed-off-by: Christoph fd0cwp@gmx.de