Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hue] Fix JUnit tests for revised ColorUtil #16559

Merged
merged 2 commits into from
Apr 28, 2024

Conversation

andrewfg
Copy link
Contributor

@andrewfg andrewfg commented Mar 22, 2024

Requires openhab/openhab-core#4124

In openhab/openhab-core#4124 we introduced some improvements in the precision of the HSB to XY color conversions. Which means that the conversions produce slightly different (more accurate) coordinates. The JUnit tests for the Hue binding depended on seeing the prior less precise coordinates. This PR modifies the JUnit tests to use the new expected XY coordinates.

Nota Bene: for this reason -- therefore -- this PR will FAIL the CI build until openhab/openhab-core#4124 will have been merged!

Signed-off-by: Andrew Fiddian-Green software@whitebear.ch

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@lolodomo
Copy link
Contributor

lolodomo commented Mar 27, 2024

To be merged just after the core PR and after a successful rebuild.

@andrewfg andrewfg removed the awaiting other PR Depends on another PR label Apr 27, 2024
@lolodomo lolodomo added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Apr 28, 2024
@lolodomo lolodomo merged commit 8329668 into openhab:main Apr 28, 2024
3 checks passed
@lolodomo lolodomo added this to the 4.2 milestone Apr 28, 2024
@lsiepel
Copy link
Contributor

lsiepel commented Apr 28, 2024

The tradfri binding tests also fail, expect the same core PR to be the cause.

@andrewfg
Copy link
Contributor Author

tradfri binding tests also fail, expect the same core PR to be the cause

Hmm. I did already test everything with the revised ColorUtil version, and it was OK when I tested it. => So was there anything recently changed in Tradfri?

@andrewfg
Copy link
Contributor Author

[ERROR] Failures:
[ERROR]   TradfriColorTest.testConversionReverse:112 expected: <11298> but was: <11299>
[ERROR]   TradfriColorTest.testFromHSBTypeKnownGood1:85 expected: <45789> but was: <45792>
[ERROR]   TradfriColorTest.testFromHSBTypeKnownGood2:98 expected: <45789> but was: <45792>
[INFO]
[ERROR] Tests run: 27, Failures: 3, Errors: 0, Skipped: 0

Yeah. I can confirm that this is indeed due to the ColorUtil improvements. I will look at it tomorrow, and push a PR to fix it..

lo92fr pushed a commit to lo92fr/openhab-addons that referenced this pull request Apr 30, 2024
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Jun 15, 2024
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Paul Smedley <paul@smedley.id.au>
@andrewfg andrewfg deleted the hue-junit-fixes branch August 25, 2024 16:02
pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 29, 2024
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this pull request Jan 2, 2025
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants