-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hue] Fix JUnit tests for revised ColorUtil #16559
Conversation
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
To be merged just after the core PR and after a successful rebuild. |
The tradfri binding tests also fail, expect the same core PR to be the cause. |
Hmm. I did already test everything with the revised ColorUtil version, and it was OK when I tested it. => So was there anything recently changed in Tradfri? |
Yeah. I can confirm that this is indeed due to the ColorUtil improvements. I will look at it tomorrow, and push a PR to fix it.. |
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> Signed-off-by: Paul Smedley <paul@smedley.id.au>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Requires openhab/openhab-core#4124
In openhab/openhab-core#4124 we introduced some improvements in the precision of the HSB to XY color conversions. Which means that the conversions produce slightly different (more accurate) coordinates. The JUnit tests for the Hue binding depended on seeing the prior less precise coordinates. This PR modifies the JUnit tests to use the new expected XY coordinates.
Nota Bene: for this reason -- therefore -- this PR will FAIL the CI build until openhab/openhab-core#4124 will have been merged!
Signed-off-by: Andrew Fiddian-Green software@whitebear.ch