-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[netatmo] Enhance bridge status reporting #16571
Conversation
Signed-off-by: clinique <gael@lhopital.org>
@jlaur : this one is ready for your review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Only one minor comment, otherwise LGTM. @lolodomo - would you like to have a look as binding maintainer?
bundles/org.openhab.binding.netatmo/src/main/resources/OH-INF/i18n/netatmo.properties
Outdated
Show resolved
Hide resolved
Signed-off-by: clinique <gael@lhopital.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @lolodomo - would you like to have a look as well?
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/netatmo-bridge-offline-99-of-time/149168/28 |
* Enhance bridge status reporting --------- Signed-off-by: clinique <gael@lhopital.org> Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
* Enhance bridge status reporting --------- Signed-off-by: clinique <gael@lhopital.org>
* Enhance bridge status reporting --------- Signed-off-by: clinique <gael@lhopital.org>
* Enhance bridge status reporting --------- Signed-off-by: clinique <gael@lhopital.org> Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
This small PR just reports the granting path in the status of the bridge so the user does not have to search in the log to find the path to grant the binding against the API
Extracted from #16489