Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[netatmo] Weather cache must be synchronized #16572

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

clinique
Copy link
Contributor

@clinique clinique commented Mar 24, 2024

Two child things may request cache update in a very small time frame, thus leading to two API calls when one would have been enough.

Extracted from #16489

Signed-off-by: clinique <gael@lhopital.org>
@clinique clinique added the enhancement An enhancement or new feature for an existing add-on label Mar 24, 2024
@clinique clinique requested a review from jlaur March 24, 2024 18:16
@clinique clinique self-assigned this Mar 24, 2024
@clinique clinique requested a review from lolodomo as a code owner March 24, 2024 18:16
@clinique
Copy link
Contributor Author

@jlaur : this one is ready for your review

Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM. @lolodomo - would you like to have a look as well?

@lolodomo lolodomo merged commit e60d090 into openhab:main Mar 25, 2024
3 checks passed
@lolodomo lolodomo added this to the 4.2 milestone Mar 25, 2024
@clinique clinique deleted the netatmo_weather_cache branch March 25, 2024 08:19
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/netatmo-bridge-offline-99-of-time/149168/28

pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 29, 2024
Signed-off-by: clinique <gael@lhopital.org>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
Signed-off-by: clinique <gael@lhopital.org>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
Signed-off-by: clinique <gael@lhopital.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants