[airgradient] Initial contribution

[austvik]

New binding: Airgradient

This binding lets you get data from https://www.airgradient.com/ air quality sensors and use them for you home automation or dashboards.

AirGradient air quality sensors are open source and open hardware, so should be attractive for home automation enthusiasts.

This binding can either poll from data from the AirGradient Cloud API or communicate directly to sensors on the network.

The binding has been tested against the latest firmware with both outdoor O-1PST and indoor I-9PSL sensors.

It has a thread here: https://community.openhab.org/t/airgradient-api-binding/152798

[austvik]

(I am not able to set "new binding" label)

[lolodomo]

It does not build. I let you check the logs but I already see that a required file is missing in bom folder.

[austvik]

It does not build. I let you check the logs but I already see that a required file is missing in bom folder.

Thank you @lolodomo ! I had some issues with forgetting signoffs on some commits and forgot that change when I started from scratch.

[holgerfriedrich]

Hi, this is not a full review and I am not a maintainer.

I just double checked for SAT warnings (just a few, see below), checked that javadoc runs without errors (the warnings are fine), and quickly looked into the README.

Find my suggestions below.

[austvik]

Thank you, @holgerfriedrich! I believe all your excellent suggestions are incorporated now.

[lsiepel]

Thanks for your contribution!. As there are more new bindings waiting to be reviewed, and usually new bindings can take up some time to be reviewed and adjusted, i would like to ask you to do a selff-review before a maintainer picks this up.
A checklist is available here: https://github.com/openhab/openhab-addons/wiki/Review-Checklist

ftr: it is not mandatory, it is just an attempt to improve the experience/time spend on PR's. Let's see if this turns out to be a step in the good direction.

[austvik]

Thank you, @lsiepel ! I'm currently traveling, but will run that self check when I am back in about a week.

[austvik]

@lsiepel I have now gone through the review checklist and fixed the two issues I found. There is one point there I might still be sinning against: 32. Cache results of getConfigAs(). Reading it more frequently got rid of many non-null warnings. Do you have any guidance for how to deal with config null safe?

[lsiepel]

Thanks for performing the self-review. Code is allready in a good shape, i just have some comments and questions.

[lsiepel]

kes sense to get this in in the

Can you give some insights of the size (lines changed) and the estimated time of publishing the PR?

[austvik]

The one with model property and separating out creating of states from the controller (for reuse):

austvik@austvik-desktop:~/src/openhab-addons$` git show 6d32039c9f111aeeec2466bf25ead30d3cb5f357 | diffstat
 main/java/org/openhab/binding/airgradient/internal/AirGradientBindingConstants.java                   |    1 
 main/java/org/openhab/binding/airgradient/internal/discovery/AirGradientLocationDiscoveryService.java |    5 +++
 main/java/org/openhab/binding/airgradient/internal/discovery/AirGradientMDNSDiscoveryParticipant.java |    4 ++
 main/java/org/openhab/binding/airgradient/internal/handler/AirGradientAPIHandler.java                 |    2 -
 main/java/org/openhab/binding/airgradient/internal/handler/AirGradientLocationHandler.java            |   53 +++++--------------------------------
 main/java/org/openhab/binding/airgradient/internal/handler/MeasureHelper.java                         |  113 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 main/java/org/openhab/binding/airgradient/internal/model/Measure.java                                 |   22 +++++++++++++++
 main/resources/OH-INF/thing/thing-types.xml                                                           |    1 
 test/java/org/openhab/binding/airgradient/internal/handler/AirGradientLocationHandlerTest.java        |    2 -
 9 files changed, 155 insertions(+), 48 deletions(-)

The local thing:

 java/org/openhab/binding/airgradient/internal/AirGradientBindingConstants.java                   |    1 +
 java/org/openhab/binding/airgradient/internal/AirGradientHandlerFactory.java                     |    9 ++++++++-
 java/org/openhab/binding/airgradient/internal/discovery/AirGradientMDNSDiscoveryParticipant.java |    6 +++---
 resources/OH-INF/thing/thing-types.xml                                                           |   52 +++++++++++++++++++++++++++++++++++++++++++++++++---
 4 files changed, 61 insertions(+), 7 deletions(-)

Both PRs are ready, but I dont want to feature creep this review unless you are OK with it.

[lsiepel]

The one with model property and separating out creating of states from the controller (for reuse):

austvik@austvik-desktop:~/src/openhab-addons$` git show 6d32039c9f111aeeec2466bf25ead30d3cb5f357 | diffstat
 main/java/org/openhab/binding/airgradient/internal/AirGradientBindingConstants.java                   |    1 
 main/java/org/openhab/binding/airgradient/internal/discovery/AirGradientLocationDiscoveryService.java |    5 +++
 main/java/org/openhab/binding/airgradient/internal/discovery/AirGradientMDNSDiscoveryParticipant.java |    4 ++
 main/java/org/openhab/binding/airgradient/internal/handler/AirGradientAPIHandler.java                 |    2 -
 main/java/org/openhab/binding/airgradient/internal/handler/AirGradientLocationHandler.java            |   53 +++++--------------------------------
 main/java/org/openhab/binding/airgradient/internal/handler/MeasureHelper.java                         |  113 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 main/java/org/openhab/binding/airgradient/internal/model/Measure.java                                 |   22 +++++++++++++++
 main/resources/OH-INF/thing/thing-types.xml                                                           |    1 
 test/java/org/openhab/binding/airgradient/internal/handler/AirGradientLocationHandlerTest.java        |    2 -
 9 files changed, 155 insertions(+), 48 deletions(-)

The local thing:

 java/org/openhab/binding/airgradient/internal/AirGradientBindingConstants.java                   |    1 +
 java/org/openhab/binding/airgradient/internal/AirGradientHandlerFactory.java                     |    9 ++++++++-
 java/org/openhab/binding/airgradient/internal/discovery/AirGradientMDNSDiscoveryParticipant.java |    6 +++---
 resources/OH-INF/thing/thing-types.xml                                                           |   52 +++++++++++++++++++++++++++++++++++++++++++++++++---
 4 files changed, 61 insertions(+), 7 deletions(-)

Both PRs are ready, but I dont want to feature creep this review unless you are OK with it.

It’s ok, just add it to this pr

[austvik]

Thank you! I'm sorry for adding more. My only defense is that May in Norway is filled with vacation days, and some of them has had bad weather :)

[austvik]

Thank you, @jlaur!

[lsiepel]

One question and some very minor last comments. I think these are the last ones.

[lsiepel]

Thanks for you contribution!

Now, you could add your binding's logo to the openHAB website. See https://www.openhab.org/docs/developer/addons/#add-your-add-on-s-logo-to-the-openhab-website

[austvik]

Thank you for great reviews @lsiepel and @jlaur. It was a great learning experience for me, and the end result was much much better than the initial submission!

[austvik]

openhab/openhab-docs#2296 Logo pull request