-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[persistence.jpa] Pin to Java 17 #16612
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a workaround to allow compiling with Java 21. Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
This was referenced Apr 5, 2024
lsiepel
approved these changes
Apr 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
holgerfriedrich
added a commit
to holgerfriedrich/openhab-addons
that referenced
this pull request
Apr 5, 2024
Support Java 21 - Upgrade openjpa from 3.2.2 to 4.0.0 - Upgrade derby from 10.14.2.0 to 10.16.1.1 (last Java 17 release) - Migrate javax.el to jakarta.el-api 6.0.0-RC1 - Revert workaround for Java 21, openhab#16612 Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
lo92fr
pushed a commit
to lo92fr/openhab-addons
that referenced
this pull request
Apr 30, 2024
This is a workaround to allow compiling with Java 21. Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
holgerfriedrich
added a commit
to holgerfriedrich/openhab-addons
that referenced
this pull request
May 25, 2024
Support Java 21 - Upgrade openjpa from 3.2.2 to 4.0.0 - Upgrade derby from 10.14.2.0 to 10.16.1.1 (last Java 17 release) - Migrate javax.el to jakarta.el-api 6.0.0-RC1 - Revert workaround for Java 21, openhab#16612 Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
lsiepel
pushed a commit
that referenced
this pull request
May 28, 2024
Support Java 21 - Upgrade openjpa from 3.2.2 to 4.0.0 - Upgrade derby from 10.14.2.0 to 10.16.1.1 (last Java 17 release) - Migrate javax.el to jakarta.el-api 6.0.0-RC1 - Revert workaround for Java 21, #16612 Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Jun 15, 2024
Support Java 21 - Upgrade openjpa from 3.2.2 to 4.0.0 - Upgrade derby from 10.14.2.0 to 10.16.1.1 (last Java 17 release) - Migrate javax.el to jakarta.el-api 6.0.0-RC1 - Revert workaround for Java 21, openhab#16612 Signed-off-by: Holger Friedrich <mail@holger-friedrich.de> Signed-off-by: Paul Smedley <paul@smedley.id.au>
pgfeller
pushed a commit
to pgfeller/openhab-addons
that referenced
this pull request
Sep 29, 2024
This is a workaround to allow compiling with Java 21. Signed-off-by: Holger Friedrich <mail@holger-friedrich.de> Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
pgfeller
pushed a commit
to pgfeller/openhab-addons
that referenced
this pull request
Sep 29, 2024
Support Java 21 - Upgrade openjpa from 3.2.2 to 4.0.0 - Upgrade derby from 10.14.2.0 to 10.16.1.1 (last Java 17 release) - Migrate javax.el to jakarta.el-api 6.0.0-RC1 - Revert workaround for Java 21, openhab#16612 Signed-off-by: Holger Friedrich <mail@holger-friedrich.de> Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993
pushed a commit
to joni1993/openhab-addons
that referenced
this pull request
Oct 15, 2024
This is a workaround to allow compiling with Java 21. Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
joni1993
pushed a commit
to joni1993/openhab-addons
that referenced
this pull request
Oct 15, 2024
Support Java 21 - Upgrade openjpa from 3.2.2 to 4.0.0 - Upgrade derby from 10.14.2.0 to 10.16.1.1 (last Java 17 release) - Migrate javax.el to jakarta.el-api 6.0.0-RC1 - Revert workaround for Java 21, openhab#16612 Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
matchews
pushed a commit
to matchews/openhab-addons
that referenced
this pull request
Oct 18, 2024
This is a workaround to allow compiling with Java 21. Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
matchews
pushed a commit
to matchews/openhab-addons
that referenced
this pull request
Oct 18, 2024
Support Java 21 - Upgrade openjpa from 3.2.2 to 4.0.0 - Upgrade derby from 10.14.2.0 to 10.16.1.1 (last Java 17 release) - Migrate javax.el to jakarta.el-api 6.0.0-RC1 - Revert workaround for Java 21, openhab#16612 Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround to allow compiling with Java 21.
Folder is pinned to create Java 17 code.
A PR #16591 is has been opened to upgrade base libraries to a version compatible with Java 21.
I do not expect it to be merged soon, as we need testing before we can proceed.
This is why the workaround should be merged in the meantime.
Refs:
openhab/openhab-distro#1590
openhab/openhab-distro#1640