[radiothermostat] Skip shutdown actions if thing offline #16677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
jlaur
requested changes
Apr 23, 2024
| } | ||
| if (ThingStatus.ONLINE.equals(this.getThing().getStatus())) { | ||
| if (isLinked(REMOTE_TEMP)) { | ||
| connector.sendCommand("rem_mode", "0", REMOTE_TEMP_RESOURCE); |
There was a problem hiding this comment.
If there is no need to do this when the thing is not online, that helps.
But the real issue is probably this blocking call. dispose is expected to be non-blocking and to return quickly - see https://www.openhab.org/docs/developer/bindings/#shutdown. So you should probably schedule a job for sending these commands.
There was a problem hiding this comment.
Gotcha, I have adjusted the code to run the calls within a job.
There was a problem hiding this comment.
I'm now wondering if there is a risk that isLinked will not work after dispose returns. I didn't check the implementation (yet), but in such a case, introducing local variables before scheduling the job might help.
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
lo92fr
pushed a commit
to lo92fr/openhab-addons
that referenced
this pull request
Apr 30, 2024
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Jun 15, 2024
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com> Signed-off-by: Paul Smedley <paul@smedley.id.au>
pgfeller
pushed a commit
to pgfeller/openhab-addons
that referenced
this pull request
Sep 29, 2024
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com> Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993
pushed a commit
to joni1993/openhab-addons
that referenced
this pull request
Oct 15, 2024
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
matchews
pushed a commit
to matchews/openhab-addons
that referenced
this pull request
Oct 18, 2024
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
cipianpascu
pushed a commit
to cipianpascu/openhab-addons
that referenced
this pull request
Jan 2, 2025
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com> Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvement to #15492. Skip shutdown actions if thing is offline to prevent slowness when the binding is disposed.