[netatmo] Fix Live Picture not always available #16679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gael@lhopital.org <gael@lhopital.org>
clinique
added
bug
Signed-off-by: root <gael@lhopital.org>
|
Channels were tested with Doorbell, Welcome and Presence. |
Signed-off-by: root <gael@lhopital.org>
lsiepel
removed
the
enhancement
lsiepel
changed the title
lolodomo
reviewed
Apr 28, 2024
...ain/java/org/openhab/binding/netatmo/internal/handler/channelhelper/CameraChannelHelper.java
Outdated
Show resolved
Hide resolved
...ain/java/org/openhab/binding/netatmo/internal/handler/channelhelper/CameraChannelHelper.java
Outdated
Show resolved
Hide resolved
...ing.netatmo/src/main/java/org/openhab/binding/netatmo/internal/api/dto/HomeStatusModule.java
Outdated
Show resolved
Hide resolved
Signed-off-by: root <gael@lhopital.org>
lolodomo
requested changes
Apr 29, 2024
...ain/java/org/openhab/binding/netatmo/internal/handler/channelhelper/CameraChannelHelper.java
Outdated
Show resolved
Hide resolved
...ain/java/org/openhab/binding/netatmo/internal/handler/channelhelper/CameraChannelHelper.java
Outdated
Show resolved
Hide resolved
...ain/java/org/openhab/binding/netatmo/internal/handler/channelhelper/CameraChannelHelper.java
Outdated
Show resolved
Hide resolved
...ain/java/org/openhab/binding/netatmo/internal/handler/channelhelper/CameraChannelHelper.java
Outdated
Show resolved
Hide resolved
Signed-off-by: root <gael@lhopital.org>
lo92fr
pushed a commit
to lo92fr/openhab-addons
that referenced
this pull request
Apr 30, 2024
* Adressing issue on live picture Signed-off-by: gael@lhopital.org <gael@lhopital.org> Signed-off-by: root <gael@lhopital.org>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Jun 15, 2024
* Adressing issue on live picture Signed-off-by: gael@lhopital.org <gael@lhopital.org> Signed-off-by: root <gael@lhopital.org> Signed-off-by: Paul Smedley <paul@smedley.id.au>
pgfeller
pushed a commit
to pgfeller/openhab-addons
that referenced
this pull request
Sep 29, 2024
* Adressing issue on live picture Signed-off-by: gael@lhopital.org <gael@lhopital.org> Signed-off-by: root <gael@lhopital.org> Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993
pushed a commit
to joni1993/openhab-addons
that referenced
this pull request
Oct 15, 2024
* Adressing issue on live picture Signed-off-by: gael@lhopital.org <gael@lhopital.org> Signed-off-by: root <gael@lhopital.org>
matchews
pushed a commit
to matchews/openhab-addons
that referenced
this pull request
Oct 18, 2024
* Adressing issue on live picture Signed-off-by: gael@lhopital.org <gael@lhopital.org> Signed-off-by: root <gael@lhopital.org>
cipianpascu
pushed a commit
to cipianpascu/openhab-addons
that referenced
this pull request
Jan 2, 2025
* Adressing issue on live picture Signed-off-by: gael@lhopital.org <gael@lhopital.org> Signed-off-by: root <gael@lhopital.org> Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially resolves issue #15883 .
Making tests, I identified that:
When camera is on local network, the default timeout (5s) can be too short (maybe long SD card reading ?) and leads to a null value => time out extended (30s)
A fallback on VPN camera live picture as been added.
Identified a race condition that lead to display live picture before localUrl or vpnUrl are set leading to UndefType.NULL in the item.
Enhanced: