-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mybmw] Revert fix images not loading anymore #16687
Merged
jlaur
merged 2 commits into
openhab:main
from
martingrassl:16642_revert_fix_image_not_loading
Apr 28, 2024
Merged
[mybmw] Revert fix images not loading anymore #16687
jlaur
merged 2 commits into
openhab:main
from
martingrassl:16642_revert_fix_image_not_loading
Apr 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to have reverted the changes in the API Signed-off-by: Martin Grassl <martin.grassl@digital-filestore.de>
jlaur
added
bug
An unexpected problem or unintended behavior of an add-on
regression
Regression that happened during the development of a release. Not shown on final release notes.
labels
Apr 26, 2024
jlaur
requested changes
Apr 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, and sorry for having to change approach again. Besides update instructions, the revert looks correct.
bundles/org.openhab.binding.mybmw/src/main/resources/OH-INF/update/thing-update.xml
Outdated
Show resolved
Hide resolved
Signed-off-by: Martin Grassl <martin.grassl@digital-filestore.de>
jlaur
approved these changes
Apr 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
jlaur
changed the title
[mybmw] revert the changes for 16642 as BMW seems to have reverted the changes in the API
[mybmw] Revert fix images not loading anymore
Apr 28, 2024
lo92fr
pushed a commit
to lo92fr/openhab-addons
that referenced
this pull request
Apr 30, 2024
…e changes in the API (openhab#16687) Signed-off-by: Martin Grassl <martin.grassl@digital-filestore.de>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Jun 15, 2024
…e changes in the API (openhab#16687) Signed-off-by: Martin Grassl <martin.grassl@digital-filestore.de> Signed-off-by: Paul Smedley <paul@smedley.id.au>
pgfeller
pushed a commit
to pgfeller/openhab-addons
that referenced
this pull request
Sep 29, 2024
…e changes in the API (openhab#16687) Signed-off-by: Martin Grassl <martin.grassl@digital-filestore.de> Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993
pushed a commit
to joni1993/openhab-addons
that referenced
this pull request
Oct 15, 2024
…e changes in the API (openhab#16687) Signed-off-by: Martin Grassl <martin.grassl@digital-filestore.de>
matchews
pushed a commit
to matchews/openhab-addons
that referenced
this pull request
Oct 18, 2024
…e changes in the API (openhab#16687) Signed-off-by: Martin Grassl <martin.grassl@digital-filestore.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
An unexpected problem or unintended behavior of an add-on
regression
Regression that happened during the development of a release. Not shown on final release notes.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unfortunately I had to revert my changes in PR #16643 as the API is working again