Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mybmw] Revert fix images not loading anymore #16687

Merged
merged 2 commits into from
Apr 28, 2024

Conversation

martingrassl
Copy link
Contributor

unfortunately I had to revert my changes in PR #16643 as the API is working again

to have reverted the changes in the API

Signed-off-by: Martin Grassl <martin.grassl@digital-filestore.de>
@jlaur jlaur added bug An unexpected problem or unintended behavior of an add-on regression Regression that happened during the development of a release. Not shown on final release notes. labels Apr 26, 2024
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, and sorry for having to change approach again. Besides update instructions, the revert looks correct.

Signed-off-by: Martin Grassl <martin.grassl@digital-filestore.de>
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jlaur jlaur merged commit bc13652 into openhab:main Apr 28, 2024
5 checks passed
@jlaur jlaur changed the title [mybmw] revert the changes for 16642 as BMW seems to have reverted the changes in the API [mybmw] Revert fix images not loading anymore Apr 28, 2024
@jlaur jlaur added this to the 4.2 milestone Apr 28, 2024
lo92fr pushed a commit to lo92fr/openhab-addons that referenced this pull request Apr 30, 2024
…e changes in the API (openhab#16687)

Signed-off-by: Martin Grassl <martin.grassl@digital-filestore.de>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Jun 15, 2024
…e changes in the API (openhab#16687)

Signed-off-by: Martin Grassl <martin.grassl@digital-filestore.de>
Signed-off-by: Paul Smedley <paul@smedley.id.au>
pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 29, 2024
…e changes in the API (openhab#16687)

Signed-off-by: Martin Grassl <martin.grassl@digital-filestore.de>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
…e changes in the API (openhab#16687)

Signed-off-by: Martin Grassl <martin.grassl@digital-filestore.de>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
…e changes in the API (openhab#16687)

Signed-off-by: Martin Grassl <martin.grassl@digital-filestore.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on regression Regression that happened during the development of a release. Not shown on final release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants