Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dynamodb] Optimize consumed read capacity #16693

Merged
merged 1 commit into from
Apr 28, 2024

Conversation

ssalonen
Copy link
Contributor

@ssalonen ssalonen commented Apr 28, 2024

We optimize consumed read capacity by limiting the queries to read at most page size entries per underlying dynamodb request. (Multiple requests might be necessary to fill page full of data)

This should significantly reduce the consumed read capacity in cases where the persistence service is queried with page size, as the default before was to read up to 1MB of data. For example, with historicState, the page size is set to 1, and only the first page is of interest.

We optimize consumed read capacity by limiting the queries to read at
most page size entries at once. This should significantly reduce the
consumed read capacity in cases where the persistence service is queried
with page size, as the default before was to read up to 1MB of data.

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@lsiepel lsiepel added the enhancement An enhancement or new feature for an existing add-on label Apr 28, 2024
@lsiepel lsiepel added this to the 4.2 milestone Apr 28, 2024
@lsiepel lsiepel merged commit dee61a7 into openhab:main Apr 28, 2024
5 checks passed
lo92fr pushed a commit to lo92fr/openhab-addons that referenced this pull request Apr 30, 2024
We optimize consumed read capacity

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Jun 15, 2024
We optimize consumed read capacity

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
Signed-off-by: Paul Smedley <paul@smedley.id.au>
pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 29, 2024
We optimize consumed read capacity

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
We optimize consumed read capacity

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
We optimize consumed read capacity

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants