-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[airq] Add Hydrogen Sulfide (H₂S) #16696
Conversation
Please rebase now the other pr is merged. |
Signed-off-by: Fabian Wolter <github@fabian-wolter.de>
Signed-off-by: Fabian Wolter <github@fabian-wolter.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a channel is added to an existing thing, upgrade instruction is needed. I should have seen this at the rebase request.
Details here: https://www.openhab.org/docs/developer/bindings/thing-xml.html#updating-thing-types
Thanks for the link! I know there was something. I searched for "Thing migration", but couldn't find anything. Now, I know why. |
Signed-off-by: Fabian Wolter <github@fabian-wolter.de>
Signed-off-by: Fabian Wolter <github@fabian-wolter.de>
I added the update instructions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks! |
* [airq] Add Hydrogen Sulfide (H₂S) Signed-off-by: Fabian Wolter <github@fabian-wolter.de> Signed-off-by: Paul Smedley <paul@smedley.id.au>
* [airq] Add Hydrogen Sulfide (H₂S) Signed-off-by: Fabian Wolter <github@fabian-wolter.de> Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
* [airq] Add Hydrogen Sulfide (H₂S) Signed-off-by: Fabian Wolter <github@fabian-wolter.de>
* [airq] Add Hydrogen Sulfide (H₂S) Signed-off-by: Fabian Wolter <github@fabian-wolter.de>
* [airq] Add Hydrogen Sulfide (H₂S) Signed-off-by: Fabian Wolter <github@fabian-wolter.de> Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
This PR depends on #16694.