Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jeelink] Add support for emt7110 energy meter #16725

Merged
merged 6 commits into from
May 9, 2024
Merged

Conversation

tischober
Copy link
Contributor

[Jeelink] support for emt7110 energy meter

Description

This is an update for the jeelink add-on. It support now the emt7110 energy meter and will show the current-power (W), consumptionTotal (kWh), electricPotential (mA) and the electricCurrent (V).

Signed-off-by: tischober <t.schober@outlook.de>
@jlaur jlaur changed the title feat: add support for emt7110 energy meter with jeelink [jeelink] Add support for emt7110 energy meter May 7, 2024
@jlaur jlaur added the enhancement An enhancement or new feature for an existing add-on label May 7, 2024
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, left some comments to fix.

Signed-off-by: tischober <t.schober@outlook.de>
Signed-off-by: tischober <t.schober@outlook.de>
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems there where some SAT errors and not used parts. Can you test this PR after these changes have been committed?

Please also update the readme.

Signed-off-by: tischober <t.schober@outlook.de>
Signed-off-by: tischober <t.schober@outlook.de>
Signed-off-by: tischober <t.schober@outlook.de>
@tischober
Copy link
Contributor Author

added the emt7110 to the readme file and also test everything again with openhab4.
I hope I did not forget anything.

Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@lsiepel lsiepel merged commit 90a2316 into openhab:main May 9, 2024
5 checks passed
@lsiepel lsiepel added this to the 4.2 milestone May 9, 2024
PRosenb pushed a commit to PRosenb/openhab-addons that referenced this pull request May 22, 2024
* feat: add support for emt7110 energy meter with jeelink

Signed-off-by: tischober <t.schober@outlook.de>
PRosenb pushed a commit to PRosenb/openhab-addons that referenced this pull request May 22, 2024
* feat: add support for emt7110 energy meter with jeelink

Signed-off-by: tischober <t.schober@outlook.de>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Jun 15, 2024
* feat: add support for emt7110 energy meter with jeelink

Signed-off-by: tischober <t.schober@outlook.de>
Signed-off-by: Paul Smedley <paul@smedley.id.au>
pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 29, 2024
* feat: add support for emt7110 energy meter with jeelink

Signed-off-by: tischober <t.schober@outlook.de>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
* feat: add support for emt7110 energy meter with jeelink

Signed-off-by: tischober <t.schober@outlook.de>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
* feat: add support for emt7110 energy meter with jeelink

Signed-off-by: tischober <t.schober@outlook.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants