-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jeelink] Add support for emt7110 energy meter #16725
Conversation
Signed-off-by: tischober <t.schober@outlook.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, left some comments to fix.
...jeelink/src/main/java/org/openhab/binding/jeelink/internal/emt7110/Emt7110SensorHandler.java
Outdated
Show resolved
Hide resolved
...link/src/main/java/org/openhab/binding/jeelink/internal/emt7110/Emt7110ReadingConverter.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.jeelink/src/main/resources/OH-INF/i18n/jeelink_de.properties
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.jeelink/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
Signed-off-by: tischober <t.schober@outlook.de>
...jeelink/src/main/java/org/openhab/binding/jeelink/internal/emt7110/Emt7110SensorHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: tischober <t.schober@outlook.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems there where some SAT errors and not used parts. Can you test this PR after these changes have been committed?
Please also update the readme.
...jeelink/src/main/java/org/openhab/binding/jeelink/internal/emt7110/Emt7110SensorHandler.java
Outdated
Show resolved
Hide resolved
...jeelink/src/main/java/org/openhab/binding/jeelink/internal/emt7110/Emt7110SensorHandler.java
Outdated
Show resolved
Hide resolved
...jeelink/src/main/java/org/openhab/binding/jeelink/internal/emt7110/Emt7110SensorHandler.java
Outdated
Show resolved
Hide resolved
...jeelink/src/main/java/org/openhab/binding/jeelink/internal/emt7110/Emt7110SensorHandler.java
Outdated
Show resolved
Hide resolved
...jeelink/src/main/java/org/openhab/binding/jeelink/internal/emt7110/Emt7110SensorHandler.java
Outdated
Show resolved
Hide resolved
...jeelink/src/main/java/org/openhab/binding/jeelink/internal/emt7110/Emt7110SensorHandler.java
Outdated
Show resolved
Hide resolved
...link/src/main/java/org/openhab/binding/jeelink/internal/emt7110/Emt7110ReadingConverter.java
Outdated
Show resolved
Hide resolved
Signed-off-by: tischober <t.schober@outlook.de>
Signed-off-by: tischober <t.schober@outlook.de>
Signed-off-by: tischober <t.schober@outlook.de>
added the emt7110 to the readme file and also test everything again with openhab4. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
* feat: add support for emt7110 energy meter with jeelink Signed-off-by: tischober <t.schober@outlook.de>
* feat: add support for emt7110 energy meter with jeelink Signed-off-by: tischober <t.schober@outlook.de>
* feat: add support for emt7110 energy meter with jeelink Signed-off-by: tischober <t.schober@outlook.de> Signed-off-by: Paul Smedley <paul@smedley.id.au>
* feat: add support for emt7110 energy meter with jeelink Signed-off-by: tischober <t.schober@outlook.de> Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
* feat: add support for emt7110 energy meter with jeelink Signed-off-by: tischober <t.schober@outlook.de>
* feat: add support for emt7110 energy meter with jeelink Signed-off-by: tischober <t.schober@outlook.de>
[Jeelink] support for emt7110 energy meter
Description
This is an update for the jeelink add-on. It support now the emt7110 energy meter and will show the current-power (W), consumptionTotal (kWh), electricPotential (mA) and the electricCurrent (V).