Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[shelly] Enable use of analog input with Shelly Plus Add-on #16744

Merged
merged 1 commit into from
May 12, 2024

Conversation

ffagerho
Copy link
Contributor

Improvement: This patch enables reading the analog input of a Shelly Plus Add-on as a percentage value when it's attached to a host Shelly device. The analogue input will show up as an external sensor channel on the Shelly Thing.

Signed-off-by: Fabian Fagerholm fabbe@paniq.net

Signed-off-by: Fabian Fagerholm <fabbe@paniq.net>
@ffagerho ffagerho requested a review from markus7017 as a code owner May 11, 2024 10:25
@lsiepel lsiepel added the enhancement An enhancement or new feature for an existing add-on label May 11, 2024
@markus7017
Copy link
Contributor

LGTM

Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks,LGTM

@lsiepel lsiepel merged commit 8b85ff1 into openhab:main May 12, 2024
5 checks passed
@lsiepel lsiepel added this to the 4.2 milestone May 12, 2024
PRosenb pushed a commit to PRosenb/openhab-addons that referenced this pull request May 22, 2024
Signed-off-by: Fabian Fagerholm <fabbe@paniq.net>
PRosenb pushed a commit to PRosenb/openhab-addons that referenced this pull request May 22, 2024
Signed-off-by: Fabian Fagerholm <fabbe@paniq.net>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Jun 15, 2024
Signed-off-by: Fabian Fagerholm <fabbe@paniq.net>
Signed-off-by: Paul Smedley <paul@smedley.id.au>
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/openhab-4-2-milestone-discussion/154316/202

pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 29, 2024
Signed-off-by: Fabian Fagerholm <fabbe@paniq.net>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
Signed-off-by: Fabian Fagerholm <fabbe@paniq.net>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
Signed-off-by: Fabian Fagerholm <fabbe@paniq.net>
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this pull request Jan 2, 2025
Signed-off-by: Fabian Fagerholm <fabbe@paniq.net>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants