[shelly] Various small fixes for BLU HT, Range Extender, Plus 10V, TRV set temp #16746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enhab#16735 Signed-off-by: Markus Michels <markus7017@gmail.com>
markus7017
added
bug
This was
linked to
issues
May 11, 2024
Signed-off-by: Markus Michels <markus7017@gmail.com>
…e with Shelly Plus 2PM Signed-off-by: Markus Michels <markus7017@gmail.com>
This was
linked to
issues
May 11, 2024
lsiepel
approved these changes
May 11, 2024
|
@markus7017 : What is the status here ? Still work in progress ? Or still waiting for additional tests ? Or just ready for a merge ? |
Signed-off-by: Markus Michels <markus7017@gmail.com>
|
@lolodomo waited for tester feedback, looks good = ready to merge |
|
@lsiepel : I let you click on merge button as you reviewed this PR. You will probably have then to close each referenced issue manually as I believe this was not declared as expected for an automatic closing. |
|
@lolodomo I marked the issues in the initial description (Closing:) or is the syntax incorrect? |
markus7017
changed the title
Yes, you can also see it on the right side: |
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Jun 15, 2024
…V set temp (openhab#16746) * fixes #openhab#16736, openhab#16734, openhab#16542, openhab#16709, openhab#16735 Signed-off-by: Markus Michels <markus7017@gmail.com> Signed-off-by: Paul Smedley <paul@smedley.id.au>
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/openhab-4-2-milestone-discussion/154316/196 |
pgfeller
pushed a commit
to pgfeller/openhab-addons
that referenced
this pull request
Sep 29, 2024
…V set temp (openhab#16746) * fixes #openhab#16736, openhab#16734, openhab#16542, openhab#16709, openhab#16735 Signed-off-by: Markus Michels <markus7017@gmail.com> Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993
pushed a commit
to joni1993/openhab-addons
that referenced
this pull request
Oct 15, 2024
…V set temp (openhab#16746) * fixes #openhab#16736, openhab#16734, openhab#16542, openhab#16709, openhab#16735 Signed-off-by: Markus Michels <markus7017@gmail.com>
matchews
pushed a commit
to matchews/openhab-addons
that referenced
this pull request
Oct 18, 2024
…V set temp (openhab#16746) * fixes #openhab#16736, openhab#16734, openhab#16542, openhab#16709, openhab#16735 Signed-off-by: Markus Michels <markus7017@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes various small fixes (1 liners)
Closing
#16736
#16734
#16542
#16709
#16655
#16724