[denonmarantz] Add HTTP protocol support for newer receivers #16748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlaur
added
enhancement
jlaur
force-pushed
the
16747-denonmarantz-http-protocol
branch
from
78661b1
to
e7706c0
Compare
jlaur
force-pushed
the
16747-denonmarantz-http-protocol
branch
2 times, most recently
from
032e3e2
to
b7aea90
Compare
jlaur
changed the title
|
Not strictly necessary as either can go first, but I'd prefer to wait for #16757 (which is ready for review now) and rebase towards that. |
jlaur
force-pushed
the
16747-denonmarantz-http-protocol
branch
4 times, most recently
from
53c6c0f
to
53cf4c7
Compare
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
|
@jlaur : is it still work in progress or ready for a merge ? |
Still work in progress, I'm awaiting some test results in the community thread in order to clarifiy if there is this direct relation:
If this is confirmed, I think the current implementation is acceptable, i.e. deriving the protocol from the port number, which should be fully backwards compatible. If not, I will need to introduce a new configuration parameter for setting the protocol revision, and the auto-configuration logic will also need some tweaking. |
jlaur
force-pushed
the
16747-denonmarantz-http-protocol
branch
from
53cf4c7
to
2419356
Compare
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
jlaur
force-pushed
the
16747-denonmarantz-http-protocol
branch
4 times, most recently
from
2c02584
to
ec5bfed
Compare
Resolves openhab#16747 Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
jlaur
force-pushed
the
16747-denonmarantz-http-protocol
branch
from
ec5bfed
to
546700e
Compare
lolodomo
requested changes
May 25, 2024
...java/org/openhab/binding/denonmarantz/internal/connector/http/DenonMarantzHttpConnector.java
Outdated
Show resolved
Hide resolved
...java/org/openhab/binding/denonmarantz/internal/connector/http/DenonMarantzHttpConnector.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
LeeC77
pushed a commit
to LeeC77/openhab-addons
that referenced
this pull request
May 27, 2024
…#16748) * Add HTTP protocol support for newer receivers Resolves openhab#16747 Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: LeeC77 <lee.charlton00@gmail.com>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Jun 15, 2024
…#16748) * Add HTTP protocol support for newer receivers Resolves openhab#16747 Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: Paul Smedley <paul@smedley.id.au>
pgfeller
pushed a commit
to pgfeller/openhab-addons
that referenced
this pull request
Sep 29, 2024
…#16748) * Add HTTP protocol support for newer receivers Resolves openhab#16747 Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993
pushed a commit
to joni1993/openhab-addons
that referenced
this pull request
Oct 15, 2024
…#16748) * Add HTTP protocol support for newer receivers Resolves openhab#16747 Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
matchews
pushed a commit
to matchews/openhab-addons
that referenced
this pull request
Oct 18, 2024
…#16748) * Add HTTP protocol support for newer receivers Resolves openhab#16747 Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API call for fetching main zone is now auto-detected. Newer receivers will return HTTP status 403 for the legacy API calls, in which case an alternative API call is now used.
Notes:
AppCommand.xmlGetSurroundModeStatus - e.g. "DOLBY AUDIO-DSUR" vs. "Dolby Audio - Dolby Surround". I don't know whatformMainZone_MainZoneXmlStatus.xmlreturns for older models.formMainZone_MainZoneXml.xmlis missing. This is used to update channelgeneral#power. It seems the logic (for my receiver) is that if any zones are on, this is on, otherwise off. The same logic could be achived from aGroup:Switch:OR(ON,OFF)item, but since this channel is updated directly from the receiver, we should not try to replicate that logic in the binding. In the case of HTTP protocol for newer receivers, this value is simply missing.Resolves #16747