[boschshc] Support for Smart Water Alarm #16770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-pace
added
the
enhancement
david-pace
force-pushed
the
16593-water-detector
branch
2 times, most recently
from
b17e9a5 to
10541f7
Compare
jlaur
approved these changes
May 18, 2024
There was a problem hiding this comment.
Flawless, many thanks! Will let @GerdZanker have a look before merging.
|
Thanks for the review @jlaur ❤️ We should also wait for the confirmation by @name-lake in #16593 whether the |
|
Hi @mherwege, I have a question about the trigger channel. In the documentation I found that the most suitable system trigger channel type would probably be I now defined the channel in <channel id="sensor-moved" typeId="system.trigger"/>But I could not find which types of commands I am supposed to send to this channel. Should I send |
|
I used it extensively in the Elro Connects binding for a similar use. I defined specific channel types for it. The handler has a method triggerChannel to trigger it. Have a look here: https://github.com/openhab/openhab-addons/tree/main/bundles/org.openhab.binding.elroconnects. |
|
@david-pace - you can also have a look at #16704 showing an end-to-end implementation of a trigger channel. |
Adds support for Bosch Smart Water Alarm devices. * add new thing type and new channel types * add new services for water detector * refactor CameraNotificationState and PrivacyModeState to a common enum EnabledDisabledState that can be re-used in the water detector tilt service states * implement handler for new device * register new device in handler factory and discovery * add unit tests * add documentation Signed-off-by: David Pace <dev@davidpace.de>
Signed-off-by: David Pace <dev@davidpace.de>
david-pace
force-pushed
the
16593-water-detector
branch
from
10541f7 to
2f89472
Compare
Signed-off-by: David Pace <dev@davidpace.de>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Jun 15, 2024
Adds support for Bosch Smart Water Alarm devices. * add new thing type and new channel types * add new services for water detector * refactor CameraNotificationState and PrivacyModeState to a common enum EnabledDisabledState that can be re-used in the water detector tilt service states * implement handler for new device * register new device in handler factory and discovery * add unit tests * add documentation Signed-off-by: David Pace <dev@davidpace.de> Signed-off-by: Paul Smedley <paul@smedley.id.au>
pgfeller
pushed a commit
to pgfeller/openhab-addons
that referenced
this pull request
Sep 29, 2024
Adds support for Bosch Smart Water Alarm devices. * add new thing type and new channel types * add new services for water detector * refactor CameraNotificationState and PrivacyModeState to a common enum EnabledDisabledState that can be re-used in the water detector tilt service states * implement handler for new device * register new device in handler factory and discovery * add unit tests * add documentation Signed-off-by: David Pace <dev@davidpace.de> Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993
pushed a commit
to joni1993/openhab-addons
that referenced
this pull request
Oct 15, 2024
Adds support for Bosch Smart Water Alarm devices. * add new thing type and new channel types * add new services for water detector * refactor CameraNotificationState and PrivacyModeState to a common enum EnabledDisabledState that can be re-used in the water detector tilt service states * implement handler for new device * register new device in handler factory and discovery * add unit tests * add documentation Signed-off-by: David Pace <dev@davidpace.de>
matchews
pushed a commit
to matchews/openhab-addons
that referenced
this pull request
Oct 18, 2024
Adds support for Bosch Smart Water Alarm devices. * add new thing type and new channel types * add new services for water detector * refactor CameraNotificationState and PrivacyModeState to a common enum EnabledDisabledState that can be re-used in the water detector tilt service states * implement handler for new device * register new device in handler factory and discovery * add unit tests * add documentation Signed-off-by: David Pace <dev@davidpace.de>
cipianpascu
pushed a commit
to cipianpascu/openhab-addons
that referenced
this pull request
Jan 2, 2025
Adds support for Bosch Smart Water Alarm devices. * add new thing type and new channel types * add new services for water detector * refactor CameraNotificationState and PrivacyModeState to a common enum EnabledDisabledState that can be re-used in the water detector tilt service states * implement handler for new device * register new device in handler factory and discovery * add unit tests * add documentation Signed-off-by: David Pace <dev@davidpace.de> Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for Bosch Smart Water Alarm devices.
closes #16593