[ipcamera] Fix ONVIF alarms streams may stop and not restart on some cameras. #16777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Signed-off-by: Matthew Skinner <matt@pcmus.com>
PRosenb
pushed a commit
to PRosenb/openhab-addons
that referenced
this pull request
May 22, 2024
…cameras. (openhab#16777) * Fault find stream Signed-off-by: Matthew Skinner <matt@pcmus.com>
PRosenb
pushed a commit
to PRosenb/openhab-addons
that referenced
this pull request
May 22, 2024
…cameras. (openhab#16777) * Fault find stream Signed-off-by: Matthew Skinner <matt@pcmus.com>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Jun 15, 2024
…cameras. (openhab#16777) * Fault find stream Signed-off-by: Matthew Skinner <matt@pcmus.com> Signed-off-by: Paul Smedley <paul@smedley.id.au>
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/problems-with-reolink-e1-outdoor/158358/7 |
pgfeller
pushed a commit
to pgfeller/openhab-addons
that referenced
this pull request
Sep 29, 2024
…cameras. (openhab#16777) * Fault find stream Signed-off-by: Matthew Skinner <matt@pcmus.com> Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993
pushed a commit
to joni1993/openhab-addons
that referenced
this pull request
Oct 15, 2024
…cameras. (openhab#16777) * Fault find stream Signed-off-by: Matthew Skinner <matt@pcmus.com>
matchews
pushed a commit
to matchews/openhab-addons
that referenced
this pull request
Oct 18, 2024
…cameras. (openhab#16777) * Fault find stream Signed-off-by: Matthew Skinner <matt@pcmus.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where some cameras reply with a different ONVIF reply content then expected and the ONVIF alarm stream halts and will not restart when this occurs. Did not effect any of the cameras that have their own API, this was only for ONVIF and also REOLINK thing types.
Hikvision: Bug fix for issue reported on forum and also confirmed it was solved with this change. The binding cleared an arraylist (?) and then tried to SET the first element. Fixed by using ADD as it can only be empty at that point in the code.
https://community.openhab.org/t/ipcamera-new-ip-camera-binding/42771/2947
Reolink: Fixed some fence post errors that were causing some cameras to show the wrong snapshot or stream from a different channel on the same NVR. This was reported on the forum and also has been confirmed as being fixed with these changes here.
https://community.openhab.org/t/adding-reolink-api-to-the-ipcamera-binding-beta-testers-needed/142202/188