[androidtv] Upgrade Bouncy Castle to 1.78 #16781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
jlaur
added
security
additional testing preferred
jlaur
changed the title
|
@morph166955 - are you able to test this? I just tried, but I cannot get the binding to work for the time being with or without the upgrade: Trace logs |
|
Did you do anything to reset your device or remove any of the files related to the PIN when updating the binding? I'm recompiling to double check right now. |
|
My two nvidia shieldtv's came right up |
|
For transparancy, this is what I did: |
With a version compiled without the upgraded dependencies, I finally managed to get through the PIN process after disabling an Android TV Thing on my production system. I'm not sure if directly related or random - do you know if it's normal not being able to have more than one connection/authenticated client at a time? However, after going back to the version with upgraded dependencies, I have so far not managed to get the PIN code to display during the pairing process, but it might be rather random. |
|
Sort of yes and sort of no. You can have two systems connect to the same device if you copy the certificates from one to the other after you finish the PIN process. That's how I'm setup here. I have my production OH connected for regular use and a second test system for dev. If you were to initiate the PIN process on a device it wipes the previous one out. This can cause issues both at the client and device side. The other thing that can break is if you have multiple things for the same device. We especially see this if someone for example configures a googletv and shieldtv or philipstv thing for the same device. I've also seen device side issues where it gets all locked up and the device needs to be rebooted. Also also, OH inside of docker can cause weird issues as well (although most of those are fixed I think). |
|
@morph166955 - I finally tried to do all these three things at the same time:
After this I was able to successfully complete the pairing again. So indeed it works, maybe the binding or the Google TV got too confused with everything I was doing. 🙂 |
jlaur
removed
the
additional testing preferred
|
Awesome. Yeah rebooting the device probably was the kicker there. I've had to do that many times in the dev process. They absolutely crash. The code on the device side is actually really flaky since it's really only meant to be used by someone who wants to connect a phone to their device for remote control purposes. We WAY over drive the intended use of the protocol stack with this binding (although it seems mostly stable). |
lsiepel
approved these changes
May 25, 2024
LeeC77
pushed a commit
to LeeC77/openhab-addons
that referenced
this pull request
May 27, 2024
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: LeeC77 <lee.charlton00@gmail.com>
jlaur
added
the
regression
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Jun 15, 2024
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: Paul Smedley <paul@smedley.id.au>
pgfeller
pushed a commit
to pgfeller/openhab-addons
that referenced
this pull request
Sep 29, 2024
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993
pushed a commit
to joni1993/openhab-addons
that referenced
this pull request
Oct 15, 2024
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
matchews
pushed a commit
to matchews/openhab-addons
that referenced
this pull request
Oct 18, 2024
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supercedes #16712
Supercedes #16766
Should fix all of these:
https://github.com/openhab/openhab-addons/security/dependabot
Related to:
Core is currently on bcpkix-jdk18on 1.77 and was on 1.76 before openhab/openhab-core#4181, so it seems the binding doesn't have to be aligned.