Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[samsungtv] Change codeowner #16784

Merged
merged 4 commits into from
Jun 14, 2024
Merged

[samsungtv] Change codeowner #16784

merged 4 commits into from
Jun 14, 2024

Conversation

NickWaterton
Copy link
Contributor

Update codeowner to @NickWaterton

@NickWaterton
[samsungtv] change codeowner
a370c22 
Signed-off-by: Nick Waterton <n.waterton@outlook.com>
@NickWaterton NickWaterton requested a review from a team as a code owner May 22, 2024 12:53
@NickWaterton NickWaterton mentioned this pull request May 22, 2024
Merged
@jlaur
Copy link
Contributor

jlaur commented May 22, 2024

@paulianttila, would you no longer like to be a maintainer of this binding? Just to be sure.

@lsiepel
Copy link
Contributor

lsiepel commented May 22, 2024

@paulianttila, would you no longer like to be a maintainer of this binding? Just to be sure.

FTR: i proposed to add @NickWaterton as second codeowner.

@jlaur
Copy link
Contributor

jlaur commented May 22, 2024

@paulianttila, would you no longer like to be a maintainer of this binding? Just to be sure.

FTR: i proposed to add @NickWaterton as second codeowner.

Sure. I found these comments:

In the meantime, the binding was heavily rewritten during the last more than two years without any review comments/objections from @paulianttila, so I guess it would be logical to promote @NickWaterton as sole maintainer. It would still be nice with a confirmation from @paulianttila before doing so.

In any case - @kaikreuzer, can you add @NickWaterton to the contributor team?

@lsiepel
Copy link
Contributor

lsiepel commented May 31, 2024

Can you fix the conflict?

@lsiepel
Copy link
Contributor

lsiepel commented Jun 11, 2024

Can you fix the conflict?

Ping @NickWaterton

@NickWaterton
Copy link
Contributor Author

Can you fix the conflict?

Ping @NickWaterton

Sorry, didn't realize you were talking to me.

What are the conflicts? how would I resolve them? there is only one file edited.

@lsiepel
Copy link
Contributor

lsiepel commented Jun 14, 2024

Can you fix the conflict?

Ping @NickWaterton

Sorry, didn't realize you were talking to me.

What are the conflicts? how would I resolve them? there is only one file edited.

If you update your fork main branch, and then your feature branch. You will get a notice about the conflict.

@NickWaterton
[samsungtv] updated codeowner to @NickWaterton
646023f 
Signed-off-by: Nick Waterton <n.waterton@outlook.com>
@NickWaterton NickWaterton reopened this Jun 14, 2024
@NickWaterton
Copy link
Contributor Author

Can you fix the conflict?

Ping @NickWaterton

Sorry, didn't realize you were talking to me.
What are the conflicts? how would I resolve them? there is only one file edited.

If you update your fork main branch, and then your feature branch. You will get a notice about the conflict.

Ok,

I tried. I still don't know what the conflict was, or if this has resolved it.

lsiepel
lsiepel reviewed Jun 14, 2024
View reviewed changes
CODEOWNERS Outdated Show resolved Hide resolved
@NickWaterton
[samsungtv] CODEOWNERS moved sansungtv below salus
0e47179 
Signed-off-by: Nick Waterton <n.waterton@outlook.com>
lsiepel
lsiepel approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@lsiepel lsiepel merged commit 18d3d5b into openhab:main Jun 14, 2024
3 of 5 checks passed
@lsiepel lsiepel added this to the 4.2 milestone Jun 14, 2024
@lsiepel lsiepel changed the title [samsungtv] documentation change codeowner [samsungtv] Change codeowner Jun 14, 2024
@NickWaterton NickWaterton deleted the samsungtv-codeowner branch June 14, 2024 19:47
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Jun 29, 2024
@NickWaterton @psmedley
[samsungtv] documentation change codeowner (openhab#16784)
7cb91bb 
* [samsungtv] change codeowner

Signed-off-by: Nick Waterton <n.waterton@outlook.com>
pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 29, 2024
@NickWaterton @pgfeller
[samsungtv] documentation change codeowner (openhab#16784)
c6033c0 
* [samsungtv] change codeowner

Signed-off-by: Nick Waterton <n.waterton@outlook.com>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
@NickWaterton @joni1993
[samsungtv] documentation change codeowner (openhab#16784)
9c28eb8 
* [samsungtv] change codeowner

Signed-off-by: Nick Waterton <n.waterton@outlook.com>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
@NickWaterton @matchews
[samsungtv] documentation change codeowner (openhab#16784)
64cc5ac 
* [samsungtv] change codeowner

Signed-off-by: Nick Waterton <n.waterton@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsiepel lsiepel lsiepel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@NickWaterton @jlaur @lsiepel