[samsungtv] Fix IllegalStateException on sourceName command

[NickWaterton]

Title

This PR fixes #16783

additional testing preferred

[jlaur]

@NickWaterton - thanks! This is the result of my first test:

2024-05-22 18:23:16.310 [INFO ] [openhab.event.ItemCommandEvent      ] - Item 'SamsungTV_SourceName' received command HDMI1/DVI
2024-05-22 18:23:16.312 [INFO ] [penhab.event.ItemStatePredictedEvent] - Item 'SamsungTV_SourceName' predicted to become HDMI1/DVI
2024-05-22 18:23:16.313 [INFO ] [openhab.event.ItemStateChangedEvent ] - Item 'SamsungTV_SourceName' changed from HDMI-CEC to HDMI1/DVI
2024-05-22 18:23:16.318 [WARN ] [internal.service.MainTVServerService] - 192.168.0.41: Command execution failed, result='NOTOK_NotConnected'
2024-05-22 18:23:16.324 [WARN ] [internal.service.MainTVServerService] - 192.168.0.41: main tvservice: command error HDMI1/DVI channel sourceName
2024-05-22 18:23:16.324 [WARN ] [tv.internal.handler.SamsungTvHandler] - 192.168.0.41: Channel 'sourceName' not connected/supported

I'll try to have a closer look later.

[jlaur]

I did another test, and it seems to be working. Maybe I enabled HDMI-CEC on the TV since I was last using the sourceName channel, and this seems to cause some confusion for me. Latest result:

2024-05-22 22:29:43.957 [INFO ] [openhab.event.ItemCommandEvent      ] - Item 'SamsungTV_SourceName' received command HDMI2
2024-05-22 22:29:43.957 [INFO ] [penhab.event.ItemStatePredictedEvent] - Item 'SamsungTV_SourceName' predicted to become HDMI2
2024-05-22 22:29:43.958 [INFO ] [openhab.event.ItemStateChangedEvent ] - Item 'SamsungTV_SourceName' changed from TV to HDMI2
2024-05-22 22:29:43.961 [DEBUG] [tv.internal.handler.SamsungTvHandler] - 192.168.0.41: Received channel: samsungtv:tv:office:sourceName, command: HDMI2
2024-05-22 22:29:43.961 [TRACE] [tv.internal.handler.SamsungTvHandler] - 192.168.0.41: Received: sourceName, command: HDMI2
2024-05-22 22:29:43.961 [TRACE] [internal.service.MainTVServerService] - 192.168.0.41: getSupportedChannelNames: [sourceName, sourceId, url, stopBrowser]
2024-05-22 22:29:43.961 [TRACE] [internal.service.MainTVServerService] - 192.168.0.41: Received channel: sourceName, command: HDMI2
2024-05-22 22:29:44.089 [DEBUG] [tv.internal.handler.SamsungTvHandler] - 192.168.0.41: Received value 'sourceName':'HDMI2' for thing 'samsungtv:tv:office'
2024-05-22 22:29:44.252 [TRACE] [internal.service.MainTVServerService] - 192.168.0.41: Received channel: sourceName, command: REFRESH
2024-05-22 22:29:45.262 [TRACE] [internal.service.MainTVServerService] - 192.168.0.41: Received channel: sourceName, command: REFRESH
2024-05-22 22:29:45.265 [DEBUG] [tv.internal.handler.SamsungTvHandler] - 192.168.0.41: Received value 'sourceName':'HDMI-CEC' for thing 'samsungtv:tv:office'
2024-05-22 22:29:45.266 [INFO ] [openhab.event.ItemStateChangedEvent ] - Item 'SamsungTV_SourceName' changed from HDMI2 to HDMI-CEC

I tried to get back to the 4.1 binding, and it has similar behavior.

The previous test where I changed source to "HDMI1/DVI" and received "Command execution failed, result='NOTOK_NotConnected'" also behaves like this in the previous version. This is probably because the HDMI device is off, so the "HDMI1/DVI" input is not available on-screen either.

Instead I can select the corresponding "HDMI-CEC" device on-screen, which will then turn on the device. This cannot be done by the binding because there are two HDMI-CEC sources. However, this works like in the previous binding, and I wouldn't know how to distinguish them from one another.

[jlaur]

LGTM