Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hdpowerview] Support SDDP addon suggestion finder #16790

Merged
merged 1 commit into from
May 31, 2024

Conversation

andrewfg
Copy link
Contributor

The HDPowerview Hub can be discovered via SDDP. This PR adds support for that.

Depends on openhab/openhab-core#4237

Signed-off-by: Andrew Fiddian-Green software@whitebear.ch

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg andrewfg added enhancement An enhancement or new feature for an existing add-on awaiting other PR Depends on another PR labels May 23, 2024
@andrewfg andrewfg self-assigned this May 23, 2024
@andrewfg
Copy link
Contributor Author

@jlaur for info.

Notes:

  1. Strictly this PR is not really necessary since the addon is already suggested vis mDNS. However it helps me to provide a live test case for New SDDP service for addon discovery and thing discovery openhab-core#4237

  2. We could eventually add a SddpDiscoveryParticipant component to the binding for discovering the respective Bridge Thing as well.

Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewfg
Copy link
Contributor Author

@jlaur just for info: I may have to revert this PR. From my testing of openhab/openhab-core#4237 it looks like the HD PowerView hub does send SDDP Alive notifications, but does not respond to SDDP Search requests. So it may be a) that the HD implementation of SDDP is broken. However it may be b) that my implementation of the core PR is broken. So we will need to get further feedback from other snapshot users to determine if it is a) or b).

@jlaur
Copy link
Contributor

jlaur commented May 25, 2024

However it may be b) that my implementation of the core PR is broken.

Perhaps @mlobstein can help by testing your core PR with #16794?

@andrewfg
Copy link
Contributor Author

Perhaps @mlobstein can help by testing your core PR with #16794?

I am counting on him.

@mlobstein
Copy link
Contributor

Perhaps @mlobstein can help by testing your core PR with #16794?

I am counting on him.

It the core PR ready to be built and tested? I am working on implementing SddpDiscoveryParticipant for epsonprojecor. The code is straight forward but needs to be exercised. I only have one device that supports SDDP, a Pana DP-UB9000, so testing will be improvised :)

@andrewfg
Copy link
Contributor Author

@jlaur just for info, the discovery in the core PR is now fixed (link below) so the HD PowerView Hub is now discovered perfectly..

openhab/openhab-core#4237 (comment)

[2024-05-27T12:17:04.230703100Z]   Client search 239.255.255.250:1902 ====
SEARCH * SDDP/1.0
Host: "192.168.1.65:3333"

[2024-05-27T12:17:05.161914900Z]   Client receive 192.168.1.168:43663 ====
SDDP/1.0 200 OK
From: "192.168.1.168:1902"
Host: "Living-Room-Hub-0026740cf2b1"
Max-Age: 1800
Type: "hunterdouglas:hub:powerviewv2"
Primary-Proxy: "hunterdouglas_powerview_hub_cin"
Proxies: "hunterdouglas_powerview_hub_cin"
Manufacturer: "HunterDouglas"
Model: "PowerView"
Driver: "hunterdouglas_powerview_hub_cin.c4z"

Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@lsiepel lsiepel merged commit cfc7463 into openhab:main May 31, 2024
5 checks passed
@lsiepel lsiepel added this to the 4.2 milestone May 31, 2024
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Jun 15, 2024
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Paul Smedley <paul@smedley.id.au>
@andrewfg andrewfg deleted the hdpowerview-sddp branch August 25, 2024 11:01
pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 29, 2024
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this pull request Jan 2, 2025
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants