-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hdpowerview] Support SDDP addon suggestion finder #16790
Conversation
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@jlaur for info. Notes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jlaur just for info: I may have to revert this PR. From my testing of openhab/openhab-core#4237 it looks like the HD PowerView hub does send SDDP Alive notifications, but does not respond to SDDP Search requests. So it may be a) that the HD implementation of SDDP is broken. However it may be b) that my implementation of the core PR is broken. So we will need to get further feedback from other snapshot users to determine if it is a) or b). |
Perhaps @mlobstein can help by testing your core PR with #16794? |
I am counting on him. |
It the core PR ready to be built and tested? I am working on implementing SddpDiscoveryParticipant for epsonprojecor. The code is straight forward but needs to be exercised. I only have one device that supports SDDP, a Pana DP-UB9000, so testing will be improvised :) |
@jlaur just for info, the discovery in the core PR is now fixed (link below) so the HD PowerView Hub is now discovered perfectly.. openhab/openhab-core#4237 (comment)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> Signed-off-by: Paul Smedley <paul@smedley.id.au>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
The HDPowerview Hub can be discovered via SDDP. This PR adds support for that.
Depends on openhab/openhab-core#4237
Signed-off-by: Andrew Fiddian-Green software@whitebear.ch