Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[denonmarantz] Provide channels icons and semantic tags #16800

Merged
merged 1 commit into from
May 25, 2024

Conversation

jlaur
Copy link
Contributor

@jlaur jlaur commented May 24, 2024

Refactored to use system channel types in order to provide icons and semantic tags (and in some cases also localized labels).

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur added the enhancement An enhancement or new feature for an existing add-on label May 24, 2024
@jlaur jlaur requested a review from jwveldhuis as a code owner May 24, 2024 21:29
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you. I have just a question.

@lolodomo lolodomo merged commit 7dcaf86 into openhab:main May 25, 2024
5 checks passed
@lolodomo lolodomo added this to the 4.2 milestone May 25, 2024
@jlaur jlaur deleted the denonmarantz-channel-icons branch May 25, 2024 11:05
LeeC77 pushed a commit to LeeC77/openhab-addons that referenced this pull request May 27, 2024
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: LeeC77 <lee.charlton00@gmail.com>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Jun 15, 2024
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Paul Smedley <paul@smedley.id.au>
pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 29, 2024
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants