Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[snmp] SNMP v3 fixes and improvements #16803

Merged
merged 5 commits into from
Jun 5, 2024
Merged

[snmp] SNMP v3 fixes and improvements #16803

merged 5 commits into from
Jun 5, 2024

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented May 26, 2024

Related to https://community.openhab.org/t/snmp-v3-passwordstring-is-null/156172

SNMPv3 had some issues when the configuration was changed because old configs were not properly removed in all cases. In addition, the engineId configuration parameter has been removed as it is now auto-discovered.

Signed-off-by: Jan N. Klug github@klug.nrw

Signed-off-by: Jan N. Klug <github@klug.nrw>
(cherry picked from commit a32af97d785f301ad2253801353af53a9941d6f9)
@J-N-K J-N-K added enhancement An enhancement or new feature for an existing add-on community approved labels May 26, 2024
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K J-N-K marked this pull request as ready for review May 26, 2024 10:53
@J-N-K J-N-K marked this pull request as draft May 26, 2024 15:27
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K J-N-K marked this pull request as ready for review May 26, 2024 16:24
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this improvements, i left two comments.

J-N-K and others added 2 commits June 5, 2024 18:44
Co-authored-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: J-N-K <github@klug.nrw>
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K
Copy link
Member Author

J-N-K commented Jun 5, 2024

All done.

@lsiepel lsiepel merged commit c2e051e into openhab:main Jun 5, 2024
5 checks passed
@lsiepel lsiepel added this to the 4.2 milestone Jun 5, 2024
@J-N-K J-N-K deleted the snmp2 branch June 5, 2024 21:31
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Jun 16, 2024
* [snmp] SNMP v3 fixes and improvements

(cherry picked from commit a32af97d785f301ad2253801353af53a9941d6f9)

Signed-off-by: Jan N. Klug <github@klug.nrw>
psmedley added a commit to psmedley/openhab-addons that referenced this pull request Jun 16, 2024
pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 29, 2024
* [snmp] SNMP v3 fixes and improvements

(cherry picked from commit a32af97d785f301ad2253801353af53a9941d6f9)

Signed-off-by: Jan N. Klug <github@klug.nrw>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
* [snmp] SNMP v3 fixes and improvements

(cherry picked from commit a32af97d785f301ad2253801353af53a9941d6f9)

Signed-off-by: Jan N. Klug <github@klug.nrw>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
* [snmp] SNMP v3 fixes and improvements

(cherry picked from commit a32af97d785f301ad2253801353af53a9941d6f9)

Signed-off-by: Jan N. Klug <github@klug.nrw>
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this pull request Jan 2, 2025
* [snmp] SNMP v3 fixes and improvements

(cherry picked from commit a32af97d785f301ad2253801353af53a9941d6f9)

Signed-off-by: Jan N. Klug <github@klug.nrw>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community approved enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants