Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[solarforecast] wait 1 hour after http 429 error #16819

Merged
merged 3 commits into from
Jun 9, 2024

Conversation

weymann
Copy link
Contributor

@weymann weymann commented May 28, 2024

Fixes #16811

After receiving http status 429 for forecast.solar API special treatment is necessary. All API calls for sf-site needs to stop for at least 1 hour to recover the OFFLINE situation.

Treatment for Clock added in order to perform valid unit tests.

Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
@pre-martin
Copy link
Contributor

+1 Showing the remaining time in the things state is great.

@lolodomo lolodomo added the bug An unexpected problem or unintended behavior of an add-on label May 31, 2024
weymann added 2 commits May 31, 2024 10:27
Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
@weymann weymann requested a review from jlaur June 2, 2024 20:08
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo merged commit 7516ca5 into openhab:main Jun 9, 2024
5 checks passed
@lolodomo lolodomo added this to the 4.2 milestone Jun 9, 2024
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Jun 16, 2024
* wait 1 hour after 429 error

Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
psmedley added a commit to psmedley/openhab-addons that referenced this pull request Jun 16, 2024
@weymann weymann deleted the fix/solarforecast-429-handling branch September 8, 2024 15:23
pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 29, 2024
* wait 1 hour after 429 error

Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
* wait 1 hour after 429 error

Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
* wait 1 hour after 429 error

Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this pull request Jan 2, 2025
* wait 1 hour after 429 error

Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[solarforecast] Binding polls remote api every minute when it receives a http error
4 participants