Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tapocontrol] Fix cloud connection error #16822

Merged
merged 1 commit into from
May 31, 2024
Merged

Conversation

wildcs
Copy link
Contributor

@wildcs wildcs commented May 29, 2024

Bugfix:
Fixed cloud connection error.

  • Http-Header: Content-Type was sent twice and this caused a 405 error on cloud response
  • Request did sent empty "params" object wich will cause an error in cloud. So "params" must be null that gson will not serialize it.

Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment.

@lolodomo lolodomo added bug An unexpected problem or unintended behavior of an add-on labels May 29, 2024
Signed-off-by: Christian Wild <christian@wildclan.de>
@wildcs wildcs requested review from lolodomo and lsiepel May 30, 2024 09:07
@lolodomo lolodomo merged commit 99eff3d into openhab:main May 31, 2024
5 checks passed
@lolodomo lolodomo added this to the 4.2 milestone May 31, 2024
@jlaur jlaur changed the title [tapocontrol] bugfix cloud connection error [tapocontrol] Fix cloud connection error May 31, 2024
@jlaur
Copy link
Contributor

jlaur commented May 31, 2024

@wildcs, @lolodomo - should this be considered for being cherry-picked into 4.1.x?

@lolodomo
Copy link
Contributor

Take care, there was massive changes in 4.2, I am not sure they were backported to 4.1. So it depends if this PR is related to these massive changes or not.

psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Jun 15, 2024
Signed-off-by: Christian Wild <christian@wildclan.de>
Signed-off-by: Paul Smedley <paul@smedley.id.au>
pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 29, 2024
Signed-off-by: Christian Wild <christian@wildclan.de>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
Signed-off-by: Christian Wild <christian@wildclan.de>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
Signed-off-by: Christian Wild <christian@wildclan.de>
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this pull request Jan 2, 2025
Signed-off-by: Christian Wild <christian@wildclan.de>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants