[solarman] Initial contribution

[catalinsanda]

As asked by @mstormi on the forum (https://community.openhab.org/t/new-solarman-v5-binding-for-deye-sofar-and-other-type-of-solar-inverters/146112/49), I'm opening a PR for the Solarman Binding.

This is a binding used to communicate with Solarman (IGEN-Tech) v5 based solar inverter data loggers in direct-mode over the local network.

[catalinsanda]

The build is failing and I don't know why. mvn clean install -pl :org.openhab.binding.solarman works locally. Can somebody point me in the right direction?

[lsiepel]

The build is failing and I don't know why. mvn clean install -pl :org.openhab.binding.solarman works locally. Can somebody point me in the right direction?

add the binding to bom/openhab-addons/pom.xml and also add yourself to the codeowner file

[lsiepel]

Thanks for your contribution. This is a partial review.
Besides these comments, you can also check that all SAT errors are fixed and no compilation warnings occur.

Edit: And fix DCO as that is mandatory.

[lsiepel]

While checking if the commit fixed the issues, i concluded not all review comments are fixed yet. I also found some new issues.

[catalinsanda]

My bad @lsiepel. I'm adding commits to the PR as I get time to implement some of the changes.
When done I'll rebase and squash them and let you know that it's ready for another round of review.

[openhab-bot]

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/new-solarman-v5-binding-for-deye-sofar-and-other-type-of-solar-inverters/146112/56

[catalinsanda]

@lsiepel - can you please give it another go?

There are still a few SAT warnings, let me know if any are blockers.

[catalinsanda]

ping @lsiepel

[lsiepel]

Unfortunately my time is limited today, but i will come back to this in the coming days. In the mean time it would be nice if you can fix these comments and also fix all SAT warnings. It is nice to see that there are no compile warnings. Merging is not far away.

[catalinsanda]

@lsiepel - fixed all SAT warnings and notices. Please give it another go.

[lsiepel]

Covered all files. Did not look a build warnings and SAT, please double check there are no build warnings and no SAT errors.

[catalinsanda]

@lsiepel - implemented CR suggestions.

For some reason I can't comment inline on #16835 (comment), so I'm putting my answer here.

I can't put the UoM in the channel definition/Item type because those channels are used for user defined requests, and the type of the value returned depends on the registers being read. Here is an example of such a usage:

Thing solarman:logger:local [ hostname="x.x.x.x", inverterType="deye_sg04lp3", serialNumber="1234567890", additionalRequests="0x03:0x27D-0x27E" ] {
Channels:
	Type number : inverter-frequency [scale="0.01", uom="Hz", rule="3", registers="0x27E"]
}

[catalinsanda]

ping @lsiepel - can you please have another look?

[lsiepel]

Thanks for addressing allmost all comments. There are 2 or 3 open ones from previous review rounds. This looks like the last review round before we can proceed to merge.

[catalinsanda]

@lsiepel - let's try again.

[lsiepel]

I'll try to look at this next week.

[lsiepel]

LGTM.

Now, you could add your binding's logo to the openHAB website. See https://next.openhab.org/docs/developer/addons/#add-your-add-on-s-logo-to-the-openhab-website-and-the-ui