Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[livisismarthome] Add support for the indoor siren device #16914

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

Novanic
Copy link
Contributor

@Novanic Novanic commented Jun 22, 2024

Adds support for the indoor siren device.

This change solves issue #16533, see issue #16533

Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
Signed-off-by: Sven Strohschein <novanic@gmx.de>
@jlaur jlaur linked an issue Jun 22, 2024 that may be closed by this pull request
@jlaur jlaur added the enhancement An enhancement or new feature for an existing add-on label Jun 22, 2024
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding siren support!

@jlaur
Copy link
Contributor

jlaur commented Jun 23, 2024

@Novanic - you have two sign-offs with different e-mail addresses. Is this intended?

@jlaur jlaur changed the title [livisismarthome] Support for the indoor siren device added [livisismarthome] Add support for the indoor siren device Jun 23, 2024
@lsiepel
Copy link
Contributor

lsiepel commented Jun 27, 2024

@Novanic - you have two sign-offs with different e-mail addresses. Is this intended?

As both used for signe off with, i merged this with both. @Novanic it is up to you to decide if you prefer to use either one for future commits.

@lsiepel lsiepel merged commit e662320 into openhab:main Jun 27, 2024
5 checks passed
@lsiepel lsiepel added this to the 4.2 milestone Jun 27, 2024
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Jun 29, 2024
…16914)

Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
Signed-off-by: Sven Strohschein <novanic@gmx.de>
pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 29, 2024
…16914)

Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
Signed-off-by: Sven Strohschein <novanic@gmx.de>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
…16914)

Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
Signed-off-by: Sven Strohschein <novanic@gmx.de>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
…16914)

Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
Signed-off-by: Sven Strohschein <novanic@gmx.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[LivisiSmarthome] Missing Support for Indoor Siren?
3 participants