-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jsscripting] Implement javax.script.Compilable
#16970
Conversation
This looks cool, is this to speed up the first run of scripts ? |
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
javax.script.Compilable
@jlaur Would be cool if you could review this - it currently does not bring a benefit but it is required for openhab/openhab-core#4289 to have an actual performance impact on UI-based JS scripts. |
Okay haha my core PR was just merged, so this does have an impact as soon as it is merged. |
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, thanks!
* [jsscripting] Restructure & Comment POM * [jsscripting] Use OPENHAB_TRANSFORMATION_SCRIPT constant from core Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
* [jsscripting] Restructure & Comment POM * [jsscripting] Use OPENHAB_TRANSFORMATION_SCRIPT constant from core Signed-off-by: Florian Hotze <florianh_dev@icloud.com> Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
* [jsscripting] Restructure & Comment POM * [jsscripting] Use OPENHAB_TRANSFORMATION_SCRIPT constant from core Signed-off-by: Florian Hotze <florianh_dev@icloud.com> (cherry picked from commit 405f402)
* [jsscripting] Restructure & Comment POM * [jsscripting] Use OPENHAB_TRANSFORMATION_SCRIPT constant from core Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
* [jsscripting] Restructure & Comment POM * [jsscripting] Use OPENHAB_TRANSFORMATION_SCRIPT constant from core Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
* [jsscripting] Restructure & Comment POM * [jsscripting] Use OPENHAB_TRANSFORMATION_SCRIPT constant from core Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
javax.script.Compilable
in preparation for [rules] Add support for pre-compilation of conditions and actions openhab-core#4289.