[enocean] Fix temperature values for D2_50 eep #16975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes openhab#16974 Signed-off-by: Zhivka Dimova <zhivka.dimova@myforest.net>
jlaur
added
bug
|
@jlaur : do we include that fix in 4.2 ? Do you think it is risky ? |
|
@lolodomo - it doesn't look risky to me, but it doesn't look critical either. |
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Jul 18, 2024
Fixes openhab#16974 Signed-off-by: Zhivka Dimova <zhivka.dimova@myforest.net>
pgfeller
pushed a commit
to pgfeller/openhab-addons
that referenced
this pull request
Sep 29, 2024
Fixes openhab#16974 Signed-off-by: Zhivka Dimova <zhivka.dimova@myforest.net> Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993
pushed a commit
to joni1993/openhab-addons
that referenced
this pull request
Oct 15, 2024
Fixes openhab#16974 Signed-off-by: Zhivka Dimova <zhivka.dimova@myforest.net>
matchews
pushed a commit
to matchews/openhab-addons
that referenced
this pull request
Oct 18, 2024
Fixes openhab#16974 Signed-off-by: Zhivka Dimova <zhivka.dimova@myforest.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16974
There is a problem with parsing the data send from fan devices using EEP D2_50 (like Dimplex)
When the value is with leading bite - 1 is converted to a number < 0 and then to unsined int which leads to a very big value for OutdorAirTempareture channel.
Looking at the code I thing this could also happen to other channels so I added a fix for them
& 0xff