[openhabcloud] Support hiding notifications and tags #16979

digitaldan · 2024-07-02T04:43:43Z

See openhab#16934 Signed-off-by: Dan Cunningham <dan@digitaldan.com>

Signed-off-by: Dan Cunningham <dan@digitaldan.com>

digitaldan · 2024-07-02T19:12:22Z

This adds notification support as well as renames severity to tag as thats actually what severity is being used for ( was super confusing with the name) . This maintains backwards compatibly so actions and old rules will continue to work that reference severity.

Signed-off-by: Dan Cunningham <dan@digitaldan.com>

digitaldan · 2024-07-02T19:29:09Z

Ok, ready for review

florian-h05

Overall LGTM, pleas have a look at my comments.

...rg.openhab.io.openhabcloud/src/main/java/org/openhab/io/openhabcloud/NotificationAction.java

....openhab.io.openhabcloud/src/main/java/org/openhab/io/openhabcloud/internal/CloudClient.java

...rg.openhab.io.openhabcloud/src/main/java/org/openhab/io/openhabcloud/NotificationAction.java

bundles/org.openhab.io.openhabcloud/README.md

jimtng

formally -> formerly

...rg.openhab.io.openhabcloud/src/main/java/org/openhab/io/openhabcloud/NotificationAction.java

Depends on openhab#16979. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>

florian-h05 · 2024-07-03T10:33:31Z

I have just published openhab-js 5.3.1 for this, and provided an add-on PR: #16985

lsiepel · 2024-07-03T11:10:04Z

I guess this should be classified as enhancement and needs to wait before 4.3 is release?

florian-h05 · 2024-07-03T11:16:31Z

I would like to get this into 4.2 - I’d consider this PR a similar situation to merging new bindings.
It extends was was added in #16938.
Even if this PR introduces a regression to that, users won’t notice it as there is currently no client-side support for the new features.

If this is not merged for 4.2.0, we either need another extension which gives us more and more method overrides for the actions, or we need to do a breaking change in 4.3.0.

jimtng · 2024-07-03T11:36:33Z

+1 for including it into 4.2. The enhanced notification had already made it in between M3 and M4. If we didin't include this PR, we'd have a method in 4.1 with 4 arguments, 4.2 with enhanced but without reference id, and 4.3 with reference id, increasing the number of different versions of the API across OH versions that we'd have to support in the helper library.

So we should consider this a part of the "enhanced notification feature" that had already made the cut into M4.

jimtng · 2024-07-03T11:38:26Z

or we need to do a breaking change in 4.3.0

Oh yes, indeed if this was postponed into 4.3.0 it would be a breaking change :(

jimtng · 2024-07-03T11:42:40Z

PS, I'll update the jruby examples in the README after this PR had been merged and the JRuby changes to support it also merged (which depends on this PR).

bundles/org.openhab.io.openhabcloud/README.md

Signed-off-by: Dan Cunningham <dan@digitaldan.com>

digitaldan · 2024-07-03T16:24:23Z

Thanks for the feedback! Changes pushed. I agree we should get this into 4.2, its important we try and get these method signatures right in one shot, otherwise we are going to prematurely introduce more complexity into the binding that is not needed yet.

digitaldan · 2024-07-03T20:27:11Z

@lsiepel This is ready to review when you are :-)

lsiepel · 2024-07-03T21:19:46Z

@lsiepel This is ready to review when you are :-)

Able to review Thursday evening, not sooner. If another maintainer is available, please proceed.

digitaldan · 2024-07-03T21:33:08Z

No worries @lsiepel ! Maybe @jlaur can take a look until then? Trying to make sure we make it in time for the 4.2 release 🙏

florian-h05 · 2024-07-03T21:41:37Z

@digitaldan Some of my review comments are still open, can you please take a look?

digitaldan · 2024-07-03T22:07:45Z

Ah, sorry i missed those, github was hiding them!

Signed-off-by: Dan Cunningham <dan@digitaldan.com>

digitaldan · 2024-07-03T22:45:15Z

Thanks @florian-h05 , hopefully i got them all this time.

florian-h05

LGTM now, thanks!

Just one minor comment:

bundles/org.openhab.io.openhabcloud/README.md

Signed-off-by: Dan Cunningham <dan@digitaldan.com>

digitaldan · 2024-07-03T23:12:53Z

Done! Thanks!

Depends on openhab#16979. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>

jlaur

Many thanks for these improvements!

Depends on #16979. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>

digitaldan · 2024-07-04T14:38:09Z

Thanks 🙌

* Support hiding notifications See openhab#16934 * Adds support for using tag over severity on extended actions Signed-off-by: Dan Cunningham <dan@digitaldan.com>

Depends on openhab#16979. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>

* Support hiding notifications See openhab#16934 * Adds support for using tag over severity on extended actions Signed-off-by: Dan Cunningham <dan@digitaldan.com> Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>

Depends on openhab#16979. Signed-off-by: Florian Hotze <florianh_dev@icloud.com> Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>

* Support hiding notifications See openhab#16934 * Adds support for using tag over severity on extended actions Signed-off-by: Dan Cunningham <dan@digitaldan.com>

Depends on openhab#16979. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>

* Support hiding notifications See openhab#16934 * Adds support for using tag over severity on extended actions Signed-off-by: Dan Cunningham <dan@digitaldan.com>

Depends on openhab#16979. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>

[openhabcloud] Support hiding notifications

1d41b23

See openhab#16934 Signed-off-by: Dan Cunningham <dan@digitaldan.com>

digitaldan requested a review from kaikreuzer as a code owner July 2, 2024 04:43

digitaldan marked this pull request as draft July 2, 2024 04:43

Adds support for using tag over severity on extended actions

95bd73f

Signed-off-by: Dan Cunningham <dan@digitaldan.com>

digitaldan changed the title ~~[openhabcloud] Support hiding notifications~~ [openhabcloud] Support hiding notifications and tags Jul 2, 2024

Update README

70ba608

Signed-off-by: Dan Cunningham <dan@digitaldan.com>

digitaldan marked this pull request as ready for review July 2, 2024 19:28

digitaldan requested a review from florian-h05 July 2, 2024 19:28

digitaldan mentioned this pull request Jul 2, 2024

[openhabcloud] Support new notification features #16934

Closed

7 tasks

florian-h05 reviewed Jul 2, 2024

View reviewed changes

jimtng requested changes Jul 3, 2024

View reviewed changes

...rg.openhab.io.openhabcloud/src/main/java/org/openhab/io/openhabcloud/NotificationAction.java Outdated Show resolved Hide resolved

jimtng mentioned this pull request Jul 3, 2024

NotificationAction: replace notify with Notification.send, add Notification.hide, support reference id. openhab/openhab-jruby#297

Merged

florian-h05 added a commit to florian-h05/openhab-addons that referenced this pull request Jul 3, 2024

[jsscripting] Upgrade to openhab-js 5.3.1

20fe104

Depends on openhab#16979. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>

florian-h05 mentioned this pull request Jul 3, 2024

[jsscripting] Upgrade to openhab-js 5.3.1 #16985

Merged

lsiepel added the enhancement An enhancement or new feature for an existing add-on label Jul 3, 2024

ccutrer reviewed Jul 3, 2024

View reviewed changes

bundles/org.openhab.io.openhabcloud/README.md Outdated Show resolved Hide resolved

digitaldan added 2 commits July 3, 2024 09:18

PR Review Feedback

12a6bad

Signed-off-by: Dan Cunningham <dan@digitaldan.com>

PR Review

425bb04

Signed-off-by: Dan Cunningham <dan@digitaldan.com>

digitaldan added 2 commits July 3, 2024 15:26

PR review changes

fa4390d

Signed-off-by: Dan Cunningham <dan@digitaldan.com>

PR refactoring

fa61cfc

Signed-off-by: Dan Cunningham <dan@digitaldan.com>

florian-h05 approved these changes Jul 3, 2024

View reviewed changes

bundles/org.openhab.io.openhabcloud/README.md Outdated Show resolved Hide resolved

PR review

adf6017

Signed-off-by: Dan Cunningham <dan@digitaldan.com>

florian-h05 added a commit to florian-h05/openhab-addons that referenced this pull request Jul 4, 2024

[jsscripting] Upgrade to openhab-js 5.3.1

d97c3f4

Depends on openhab#16979. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>

kaikreuzer requested a review from jimtng July 4, 2024 08:50

florian-h05 added a commit to florian-h05/openhab-addons that referenced this pull request Jul 4, 2024

[jsscripting] Upgrade to openhab-js 5.3.1

f177cdf

Depends on openhab#16979. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>

jimtng approved these changes Jul 4, 2024

View reviewed changes

jlaur approved these changes Jul 4, 2024

View reviewed changes

jlaur merged commit 2d7c9a2 into openhab:main Jul 4, 2024
5 checks passed

jlaur added this to the 4.2 milestone Jul 4, 2024

jlaur pushed a commit that referenced this pull request Jul 4, 2024

[jsscripting] Upgrade to openhab-js 5.3.1 (#16985)

2d41202

Depends on #16979. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>

psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Jul 12, 2024

[jsscripting] Upgrade to openhab-js 5.3.1 (openhab#16985)

3e96f17

Depends on openhab#16979. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>

joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024

[jsscripting] Upgrade to openhab-js 5.3.1 (openhab#16985)

1adac31

Depends on openhab#16979. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>

matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024

[jsscripting] Upgrade to openhab-js 5.3.1 (openhab#16985)

928ade1

Depends on openhab#16979. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[openhabcloud] Support hiding notifications and tags #16979

[openhabcloud] Support hiding notifications and tags #16979

digitaldan commented Jul 2, 2024

digitaldan commented Jul 2, 2024

digitaldan commented Jul 2, 2024

florian-h05 left a comment

jimtng left a comment

florian-h05 commented Jul 3, 2024 •

edited

Loading

lsiepel commented Jul 3, 2024

florian-h05 commented Jul 3, 2024 •

edited

Loading

jimtng commented Jul 3, 2024

jimtng commented Jul 3, 2024

jimtng commented Jul 3, 2024

digitaldan commented Jul 3, 2024

digitaldan commented Jul 3, 2024

lsiepel commented Jul 3, 2024

digitaldan commented Jul 3, 2024

florian-h05 commented Jul 3, 2024

digitaldan commented Jul 3, 2024

digitaldan commented Jul 3, 2024

florian-h05 left a comment

digitaldan commented Jul 3, 2024

jlaur left a comment

digitaldan commented Jul 4, 2024

[openhabcloud] Support hiding notifications and tags #16979

[openhabcloud] Support hiding notifications and tags #16979

Conversation

digitaldan commented Jul 2, 2024

digitaldan commented Jul 2, 2024

digitaldan commented Jul 2, 2024

florian-h05 left a comment

Choose a reason for hiding this comment

jimtng left a comment

Choose a reason for hiding this comment

florian-h05 commented Jul 3, 2024 • edited Loading

lsiepel commented Jul 3, 2024

florian-h05 commented Jul 3, 2024 • edited Loading

jimtng commented Jul 3, 2024

jimtng commented Jul 3, 2024

jimtng commented Jul 3, 2024

digitaldan commented Jul 3, 2024

digitaldan commented Jul 3, 2024

lsiepel commented Jul 3, 2024

digitaldan commented Jul 3, 2024

florian-h05 commented Jul 3, 2024

digitaldan commented Jul 3, 2024

digitaldan commented Jul 3, 2024

florian-h05 left a comment

Choose a reason for hiding this comment

digitaldan commented Jul 3, 2024

jlaur left a comment

Choose a reason for hiding this comment

digitaldan commented Jul 4, 2024

florian-h05 commented Jul 3, 2024 •

edited

Loading

florian-h05 commented Jul 3, 2024 •

edited

Loading