Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[growatt] Annotate ThingActions implementation as a Component #16986

Merged
merged 1 commit into from
Jul 3, 2024
Merged

[growatt] Annotate ThingActions implementation as a Component #16986

merged 1 commit into from
Jul 3, 2024

Conversation

andrewfg
Copy link
Contributor

@andrewfg andrewfg commented Jul 3, 2024

The ThingActions implementation must be annotated as a Component

Signed-off-by: Andrew Fiddian-Green software@whitebear.ch

@andrewfg
[growatt] annotate ThingActions implementation as a Component
9e3cdfe 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg andrewfg added the bug An unexpected problem or unintended behavior of an add-on label Jul 3, 2024
@andrewfg andrewfg requested a review from a team July 3, 2024 10:35
@andrewfg andrewfg self-assigned this Jul 3, 2024
lsiepel
lsiepel approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@lsiepel lsiepel merged commit c20871d into openhab:main Jul 3, 2024
5 checks passed
@jlaur jlaur added this to the 4.2 milestone Jul 3, 2024
@jlaur jlaur added the regression Regression that happened during the development of a release. Not shown on final release notes. label Jul 3, 2024
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Jul 12, 2024
@andrewfg @psmedley
[growatt] annotate ThingActions implementation as a Component (openha…
a5389df 
…b#16986)

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg andrewfg deleted the growatt-actions branch August 25, 2024 13:27
pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 29, 2024
@andrewfg @pgfeller
[growatt] annotate ThingActions implementation as a Component (openha…
03405f5 
…b#16986)

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
@andrewfg @joni1993
[growatt] annotate ThingActions implementation as a Component (openha…
a3865eb 
…b#16986)

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
@andrewfg @matchews
[growatt] annotate ThingActions implementation as a Component (openha…
af268f7 
…b#16986)

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsiepel lsiepel lsiepel approved these changes

Assignees

@andrewfg andrewfg

Labels
bug An unexpected problem or unintended behavior of an add-on regression Regression that happened during the development of a release. Not shown on final release notes.
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewfg @lsiepel @jlaur