Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[freeboxos] Change default HTTPS port #17086

Merged
merged 1 commit into from
Jul 31, 2024
Merged

[freeboxos] Change default HTTPS port #17086

merged 1 commit into from
Jul 31, 2024

Conversation

lolodomo
Copy link
Contributor

Set default to 443 as it is the default HTTPS port to use to connect to mafreebox.freebox.fr.

Fix #17075

Signed-off-by: Laurent Garnier lg.hc@free.fr

@lolodomo
[freeboxos] Change default HTTPS port
35a32b9 
Set default to 443 as it is the default HTTPS port to use to connect to mafreebox.freebox.fr.

Fix openhab#17075

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo lolodomo added the bug An unexpected problem or unintended behavior of an add-on label Jul 17, 2024
@lolodomo lolodomo requested a review from clinique as a code owner July 17, 2024 05:44
@lolodomo
Copy link
Contributor Author

Please wait @clinique approval before merging.
Maybe there is a mystery I am not understanding. Do you need port 15682 to access mafreebox.freebox.fr ? For the Freebox Revolution, I have to use port 443.

lsiepel
lsiepel approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clinique
Copy link
Contributor

Yes, I'll dig this - this port number does not come out of the blue

@lsiepel
Copy link
Contributor

lsiepel commented Jul 17, 2024

Yes, I'll dig this - this port number does not come out of the blue

Sorry, you approve the PR (the port wil change from 15682 to 443) or not?

@lolodomo
Copy link
Contributor Author

lolodomo commented Jul 17, 2024 •
edited
Loading

Sorry, you approve the PR (the port wil change from 15682 to 443) or not?

He wants first to understand why he sets it to 15682.
So, we are waiting for his feedback.
Until that, the workaround is to not rely on default but set the parameter to 443.

@clinique
Copy link
Contributor

I'm unable to test / analyze it until the end of the month.

@lolodomo
Copy link
Contributor Author

I'm unable to test / analyze it until the end of the month.

No hurry as there is a workaround.

@lsiepel lsiepel added the additional testing preferred The change works for the pull request author. A test from someone else is preferred though. label Jul 21, 2024
@clinique
Copy link
Contributor

@lolodomo : you can proceed with this one, I did not find any obvious reason for using 15682 (I'm using 27068 on my side).

clinique
clinique approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@clinique clinique left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lsiepel lsiepel removed the additional testing preferred The change works for the pull request author. A test from someone else is preferred though. label Jul 31, 2024
@lsiepel lsiepel merged commit 57ca708 into openhab:main Jul 31, 2024
5 checks passed
@lsiepel lsiepel added this to the 4.3 milestone Jul 31, 2024
@lolodomo lolodomo deleted the freeboxos_default_httpsPort branch July 31, 2024 13:53
digitaldan pushed a commit to digitaldan/openhab-addons that referenced this pull request Aug 29, 2024
@lolodomo @digitaldan
[freeboxos] Change default HTTPS port (openhab#17086)
b131e1b 
Set default to 443 as it is the default HTTPS port to use to connect to mafreebox.freebox.fr.
Fix openhab#17075

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 29, 2024
@lolodomo @pgfeller
[freeboxos] Change default HTTPS port (openhab#17086)
27c7475 
Set default to 443 as it is the default HTTPS port to use to connect to mafreebox.freebox.fr.
Fix openhab#17075

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
@lolodomo @joni1993
[freeboxos] Change default HTTPS port (openhab#17086)
8177038 
Set default to 443 as it is the default HTTPS port to use to connect to mafreebox.freebox.fr.
Fix openhab#17075

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
@lolodomo @matchews
[freeboxos] Change default HTTPS port (openhab#17086)
0f21151 
Set default to 443 as it is the default HTTPS port to use to connect to mafreebox.freebox.fr.
Fix openhab#17075

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this pull request Jan 2, 2025
@lolodomo
[freeboxos] Change default HTTPS port (openhab#17086)
640396c 
Set default to 443 as it is the default HTTPS port to use to connect to mafreebox.freebox.fr.
Fix openhab#17075

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsiepel lsiepel lsiepel approved these changes

@clinique clinique clinique approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

[freeboxos] Strange default value for parameter httpsPort
3 participants
@lolodomo @clinique @lsiepel