[daikin] Add demand control support for ac_unit #17087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsiepel
added
the
enhancement
jimtng
force-pushed
the
daikin-demand
branch
2 times, most recently
from
5a95d70 to
556c994
Compare
jimtng
changed the title
ac_unit Thing.
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
lsiepel
approved these changes
Jul 25, 2024
There was a problem hiding this comment.
Thanks, LGTM. Would be nice if @caffineehacker can comment.
|
AFAIK, we haven't heard from @caffineehacker about this binding in years (at least 4 years that I know of) |
He seems active on github, maybe not getting these notification? Or if he abondoned this binding, it would be nice to get a comment from him and we can remove him as codewoner. Ping @caffineehacker |
digitaldan
pushed a commit
to digitaldan/openhab-addons
that referenced
this pull request
Aug 29, 2024
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
pgfeller
pushed a commit
to pgfeller/openhab-addons
that referenced
this pull request
Sep 29, 2024
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au> Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993
pushed a commit
to joni1993/openhab-addons
that referenced
this pull request
Oct 15, 2024
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
matchews
pushed a commit
to matchews/openhab-addons
that referenced
this pull request
Oct 18, 2024
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #16479 and #17036