-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[freeboxos] Remove macAddress as thing configuration parameter #17088
Conversation
d4c7c6b
to
aeed35e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM. Waiting for @clinique approval.
I also removed the configuration parameter from player and active-player thing types. |
I have to apply the same for vm and repeater. |
For server, revolution, player, active-player, repeater and vm thing types Replace it by a thing property. Fix openhab#17076 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
e57c014
to
e8130d8
Compare
It is now ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@clinique for approval
…ab#17088) For server, revolution, player, active-player, repeater and vm thing types Replace it by a thing property. Fix openhab#17076 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
…ab#17088) For server, revolution, player, active-player, repeater and vm thing types Replace it by a thing property. Fix openhab#17076 Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
…ab#17088) For server, revolution, player, active-player, repeater and vm thing types Replace it by a thing property. Fix openhab#17076 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
…ab#17088) For server, revolution, player, active-player, repeater and vm thing types Replace it by a thing property. Fix openhab#17076 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
…ab#17088) For server, revolution, player, active-player, repeater and vm thing types Replace it by a thing property. Fix openhab#17076 Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
For server, revolution, player, active-player, repeater and vm thing types.
Replace it by a thing property.
Fix #17076
Signed-off-by: Laurent Garnier lg.hc@free.fr