Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[freeboxos] Remove macAddress as thing configuration parameter #17088

Merged
merged 1 commit into from
Aug 3, 2024

Conversation

lolodomo
Copy link
Contributor

@lolodomo lolodomo commented Jul 17, 2024

For server, revolution, player, active-player, repeater and vm thing types.
Replace it by a thing property.

Fix #17076

Signed-off-by: Laurent Garnier lg.hc@free.fr

@lolodomo lolodomo added the bug An unexpected problem or unintended behavior of an add-on label Jul 17, 2024
@lolodomo lolodomo requested a review from clinique as a code owner July 17, 2024 09:44
@lolodomo lolodomo marked this pull request as draft July 17, 2024 09:55
@lolodomo lolodomo force-pushed the freeboxos_macaddress branch from d4c7c6b to aeed35e Compare July 17, 2024 10:11
@lolodomo lolodomo marked this pull request as ready for review July 17, 2024 10:12
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM. Waiting for @clinique approval.

@lolodomo
Copy link
Contributor Author

I also removed the configuration parameter from player and active-player thing types.

@lolodomo lolodomo marked this pull request as draft July 18, 2024 13:46
@lolodomo
Copy link
Contributor Author

I have to apply the same for vm and repeater.

For server, revolution, player, active-player, repeater and vm thing types
Replace it by a thing property.

Fix openhab#17076

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo lolodomo force-pushed the freeboxos_macaddress branch from e57c014 to e8130d8 Compare July 22, 2024 06:40
@lolodomo lolodomo marked this pull request as ready for review July 22, 2024 06:42
@lolodomo
Copy link
Contributor Author

It is now ready for review.

Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clinique for approval

@lsiepel lsiepel merged commit 1499928 into openhab:main Aug 3, 2024
5 checks passed
@lolodomo lolodomo deleted the freeboxos_macaddress branch August 3, 2024 16:45
@lsiepel lsiepel added this to the 4.3 milestone Aug 3, 2024
digitaldan pushed a commit to digitaldan/openhab-addons that referenced this pull request Aug 29, 2024
…ab#17088)

For server, revolution, player, active-player, repeater and vm thing types
Replace it by a thing property.

Fix openhab#17076

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 29, 2024
…ab#17088)

For server, revolution, player, active-player, repeater and vm thing types
Replace it by a thing property.

Fix openhab#17076

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
…ab#17088)

For server, revolution, player, active-player, repeater and vm thing types
Replace it by a thing property.

Fix openhab#17076

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
…ab#17088)

For server, revolution, player, active-player, repeater and vm thing types
Replace it by a thing property.

Fix openhab#17076

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this pull request Jan 2, 2025
…ab#17088)

For server, revolution, player, active-player, repeater and vm thing types
Replace it by a thing property.

Fix openhab#17076

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[freeboxos] macAddress parameter really required for server thing?
3 participants