-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[freeboxos] Fix systeminfo group for active-player thing type #17097
Merged
lsiepel
merged 3 commits into
openhab:main
from
lolodomo:freeboxos_player_fix_systeminfo
Jul 27, 2024
Merged
[freeboxos] Fix systeminfo group for active-player thing type #17097
lsiepel
merged 3 commits into
openhab:main
from
lolodomo:freeboxos_player_fix_systeminfo
Jul 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And remove this group from player thing type. Signed-off-by: Laurent Garnier <lg.hc@free.fr>
For the Thing upgrade instructions i could not find how to handle this change. Should there be any upgrade instructions? |
We could remove the 3 channels and add them again (only 2 of 3). |
I can't advice here as there does not seem to be documentation and i have no experiences with this specfific use case. |
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Things upgrade tested successfully. |
lsiepel
approved these changes
Jul 27, 2024
digitaldan
pushed a commit
to digitaldan/openhab-addons
that referenced
this pull request
Aug 29, 2024
…b#17097) * [freeboxos] Fix systeminfo group for active-player thing type And remove this group from player thing type. Signed-off-by: Laurent Garnier <lg.hc@free.fr>
pgfeller
pushed a commit
to pgfeller/openhab-addons
that referenced
this pull request
Sep 29, 2024
…b#17097) * [freeboxos] Fix systeminfo group for active-player thing type And remove this group from player thing type. Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993
pushed a commit
to joni1993/openhab-addons
that referenced
this pull request
Oct 15, 2024
…b#17097) * [freeboxos] Fix systeminfo group for active-player thing type And remove this group from player thing type. Signed-off-by: Laurent Garnier <lg.hc@free.fr>
matchews
pushed a commit
to matchews/openhab-addons
that referenced
this pull request
Oct 18, 2024
…b#17097) * [freeboxos] Fix systeminfo group for active-player thing type And remove this group from player thing type. Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And remove this group from player thing type.
Signed-off-by: Laurent Garnier lg.hc@free.fr