Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[freeboxos] Fix systeminfo group for active-player thing type #17097

Merged
merged 3 commits into from
Jul 27, 2024

Conversation

lolodomo
Copy link
Contributor

And remove this group from player thing type.

Signed-off-by: Laurent Garnier lg.hc@free.fr

And remove this group from player thing type.

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo lolodomo added the bug An unexpected problem or unintended behavior of an add-on label Jul 18, 2024
@lolodomo lolodomo requested a review from clinique as a code owner July 18, 2024 11:32
@lsiepel
Copy link
Contributor

lsiepel commented Jul 19, 2024

For the Thing upgrade instructions i could not find how to handle this change. Should there be any upgrade instructions?

@lolodomo
Copy link
Contributor Author

We could remove the 3 channels and add them again (only 2 of 3).

@lsiepel
Copy link
Contributor

lsiepel commented Jul 21, 2024

We could remove the 3 channels and add them again (only 2 of 3).

I can't advice here as there does not seem to be documentation and i have no experiences with this specfific use case.

@lsiepel lsiepel requested a review from jlaur July 22, 2024 08:15
@lolodomo
Copy link
Contributor Author

Things upgrade tested successfully.

@lsiepel lsiepel merged commit 5b3f96e into openhab:main Jul 27, 2024
5 checks passed
@lsiepel lsiepel added this to the 4.3 milestone Jul 27, 2024
@lolodomo lolodomo deleted the freeboxos_player_fix_systeminfo branch July 27, 2024 12:29
digitaldan pushed a commit to digitaldan/openhab-addons that referenced this pull request Aug 29, 2024
…b#17097)

* [freeboxos] Fix systeminfo group for active-player thing type

And remove this group from player thing type.

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 29, 2024
…b#17097)

* [freeboxos] Fix systeminfo group for active-player thing type

And remove this group from player thing type.

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
…b#17097)

* [freeboxos] Fix systeminfo group for active-player thing type

And remove this group from player thing type.

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
…b#17097)

* [freeboxos] Fix systeminfo group for active-player thing type

And remove this group from player thing type.

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants