Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[samsungtv] Adjust logging when TV is off #17119

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Conversation

lsiepel
Copy link
Contributor

@lsiepel lsiepel commented Jul 21, 2024

As the Thing is already set to offline later on, there is no need to also log to warn level that the device is unreachable / timeout for getting the TV Properties. debug is good enough.

Fixes: #17118

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
@lsiepel lsiepel added the bug An unexpected problem or unintended behavior of an add-on label Jul 21, 2024
@lsiepel lsiepel requested a review from a team July 21, 2024 18:11
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo merged commit 2bc890c into openhab:main Aug 12, 2024
5 checks passed
@lolodomo lolodomo added this to the 4.3 milestone Aug 12, 2024
@lsiepel lsiepel deleted the samsung-log branch August 12, 2024 12:06
digitaldan pushed a commit to digitaldan/openhab-addons that referenced this pull request Aug 29, 2024
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 29, 2024
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[samsungtv] Loging that is duplicate to the Thing state
2 participants