Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[homekit] Implement StatelessProgrammableSwitch #17129

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

ccutrer
Copy link
Contributor

@ccutrer ccutrer commented Jul 22, 2024

Also supports adding multiple of them in a group, by supporting ServiceIndex as an optional characteristic

Refs #9969

@ccutrer ccutrer requested review from andylintner and yfre as code owners July 22, 2024 19:11
also supports adding multiple of them in a group, by supporting ServiceIndex
as an optional characteristic

refs openhab#9969

Signed-off-by: Cody Cutrer <cody@cutrer.us>
@ccutrer ccutrer force-pushed the homekit-stateless-programmable-switch branch from 270403f to 0b13094 Compare July 22, 2024 19:14
@lsiepel lsiepel added enhancement An enhancement or new feature for an existing add-on rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Jul 22, 2024
Copy link
Contributor

@yfre yfre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for doing it. i tried to implement stateless switch multiple time but it was that special so that i was not sure how integrate it into the existing source code.

LGTM

i would only reduce the logging as it is not helpful for the users anyway.

@lsiepel lsiepel merged commit cbbc366 into openhab:main Jul 23, 2024
5 checks passed
@lsiepel lsiepel added this to the 4.3 milestone Jul 23, 2024
@ccutrer ccutrer deleted the homekit-stateless-programmable-switch branch July 23, 2024 14:58
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/homekit-integration-beta/157125/1

digitaldan pushed a commit to digitaldan/openhab-addons that referenced this pull request Aug 29, 2024
also supports adding multiple of them in a group, by supporting ServiceIndex
as an optional characteristic

refs openhab#9969

Signed-off-by: Cody Cutrer <cody@cutrer.us>
pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 29, 2024
also supports adding multiple of them in a group, by supporting ServiceIndex
as an optional characteristic

refs openhab#9969

Signed-off-by: Cody Cutrer <cody@cutrer.us>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
also supports adding multiple of them in a group, by supporting ServiceIndex
as an optional characteristic

refs openhab#9969

Signed-off-by: Cody Cutrer <cody@cutrer.us>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
also supports adding multiple of them in a group, by supporting ServiceIndex
as an optional characteristic

refs openhab#9969

Signed-off-by: Cody Cutrer <cody@cutrer.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants