-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[homekit] Implement StatelessProgrammableSwitch #17129
[homekit] Implement StatelessProgrammableSwitch #17129
Conversation
also supports adding multiple of them in a group, by supporting ServiceIndex as an optional characteristic refs openhab#9969 Signed-off-by: Cody Cutrer <cody@cutrer.us>
270403f
to
0b13094
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for doing it. i tried to implement stateless switch multiple time but it was that special so that i was not sure how integrate it into the existing source code.
LGTM
i would only reduce the logging as it is not helpful for the users anyway.
...penhab.io.homekit/src/main/java/org/openhab/io/homekit/internal/HomekitAccessoryUpdater.java
Show resolved
Hide resolved
.../src/main/java/org/openhab/io/homekit/internal/accessories/HomekitCharacteristicFactory.java
Show resolved
Hide resolved
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/homekit-integration-beta/157125/1 |
also supports adding multiple of them in a group, by supporting ServiceIndex as an optional characteristic refs openhab#9969 Signed-off-by: Cody Cutrer <cody@cutrer.us>
also supports adding multiple of them in a group, by supporting ServiceIndex as an optional characteristic refs openhab#9969 Signed-off-by: Cody Cutrer <cody@cutrer.us> Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
also supports adding multiple of them in a group, by supporting ServiceIndex as an optional characteristic refs openhab#9969 Signed-off-by: Cody Cutrer <cody@cutrer.us>
also supports adding multiple of them in a group, by supporting ServiceIndex as an optional characteristic refs openhab#9969 Signed-off-by: Cody Cutrer <cody@cutrer.us>
Also supports adding multiple of them in a group, by supporting ServiceIndex as an optional characteristic
Refs #9969