Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mercedesme] Additional mappings and channels #17143

Merged
merged 23 commits into from
Aug 29, 2024
Merged

[mercedesme] Additional mappings and channels #17143

merged 23 commits into from
Aug 29, 2024

Conversation

weymann
Copy link
Contributor

@weymann weymann commented Jul 24, 2024 •
edited
Loading

Fixes #17266

  • Mappings added

    • service#starterBattery
    • tires#sensor-available
    • tires#marker*

  • Channels added
    see readme

    • eco group (new)

      • accel - Acceleration Score
      • coasting- Coasting Score
      • constant - Constant Driving Score
      • bonus - Bonus range towards very sportive driver

    • hvac group

      • ac-status - Status of preconditioning command
      • aux-status - Status of auxiliary heating command

    • charge group

      • status - Status of charging
      • error - In case of problem description of error

    • position group

      • status - Positioning status

@weymann weymann requested a review from lsiepel July 24, 2024 17:10
@lsiepel lsiepel added the enhancement An enhancement or new feature for an existing add-on label Jul 24, 2024
lsiepel
lsiepel requested changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Very minor comments.
The thing upgrade instructions are missing for the eco group. the other new and changed channels are added dynamically so they don;t need instructions.

bundles/org.openhab.binding.mercedesme/src/main/resources/OH-INF/thing/eco-channel-types.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.mercedesme/src/main/resources/OH-INF/thing/hvac-channel-types.xml Outdated Show resolved Hide resolved
@weymann
Copy link
Contributor Author

weymann commented Jul 27, 2024

The thing upgrade instructions are missing for the eco group. the other new and changed channels are added dynamically so they don;t need instructions.

Added instructions.xml in OH-INF/update for added and updated channels: Please double check because till now I wasn't familiar with that.

@lsiepel
Copy link
Contributor

lsiepel commented Aug 20, 2024

The thing upgrade instructions are missing for the eco group. the other new and changed channels are added dynamically so they don;t need instructions.

Added instructions.xml in OH-INF/update for added and updated channels: Please double check because till now I wasn't familiar with that.

They are fine. Only thing to add is that you also need to set the proiperty thingTypeVersion for each thing in their xml structure.

		<properties>
			<property name="thingTypeVersion">1</property>
		</properties>

@lsiepel lsiepel added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Aug 20, 2024
@weymann
Copy link
Contributor Author

weymann commented Aug 20, 2024

The thing upgrade instructions are missing for the eco group. the other new and changed channels are added dynamically so they don;t need instructions.

Added instructions.xml in OH-INF/update for added and updated channels: Please double check because till now I wasn't familiar with that.

They are fine. Only thing to add is that you also need to set the proiperty thingTypeVersion for each thing in their xml structure.

		<properties>
			<property name="thingTypeVersion">1</property>
		</properties>

I really need some help here. Documentation available is not really covering all possible problems so I am guessing around what's the right instructions.
I've a similar problem with #17265 where I try out different solutions but the tutorial above doesn't provide any hint to solve it.

@lsiepel
Copy link
Contributor

lsiepel commented Aug 29, 2024

As you managed to fix the other PR, can you fix the conflict and proceed or do you need some specific information to continue. Let me now an i'll do the best i can.

lsiepel
lsiepel approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lsiepel lsiepel merged commit d9a0039 into openhab:main Aug 29, 2024
5 checks passed
@lsiepel lsiepel added this to the 4.3 milestone Aug 29, 2024
digitaldan pushed a commit to digitaldan/openhab-addons that referenced this pull request Sep 24, 2024
@weymann @digitaldan
[mercedesme] Additional mappings and channels (openhab#17143)
4948d2b 
* starter battery mappings

Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 29, 2024
@weymann @pgfeller
[mercedesme] Additional mappings and channels (openhab#17143)
51b945a 
* starter battery mappings

Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
@weymann @joni1993
[mercedesme] Additional mappings and channels (openhab#17143)
bea77c3 
* starter battery mappings

Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
@weymann @matchews
[mercedesme] Additional mappings and channels (openhab#17143)
cceb02f 
* starter battery mappings

Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this pull request Jan 2, 2025
@weymann
[mercedesme] Additional mappings and channels (openhab#17143)
b6ce04d 
* starter battery mappings

Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsiepel lsiepel lsiepel approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

[mercedesme] Duplicate channels mercedesme:bev:mercedesme_account:...hvac#aux-status
2 participants
@weymann @lsiepel