Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[homekit] Allow linking GarageDoorOpener directly to a Rollershutter #17150

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

ccutrer
Copy link
Contributor

@ccutrer ccutrer commented Jul 25, 2024

A Rollershutter is a common choice for modeling a GarageDoorOpener in openHAB (it's how the old MyQ binding represented it, and how RATGDO via ESPHome models it), so it's helpful to allow very simple configuration of HomeKit with it.

@ccutrer ccutrer requested review from andylintner and yfre as code owners July 25, 2024 15:00
@ccutrer ccutrer requested a review from lsiepel July 25, 2024 15:38
@ccutrer ccutrer force-pushed the homekit-garage-door-rollershutter branch from fa0f619 to 4b56df8 Compare July 30, 2024 17:36
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM

@lsiepel lsiepel merged commit 213a0b7 into openhab:main Aug 1, 2024
5 checks passed
@lsiepel lsiepel added the enhancement An enhancement or new feature for an existing add-on label Aug 1, 2024
@lsiepel lsiepel added this to the 4.3 milestone Aug 1, 2024
@ccutrer ccutrer deleted the homekit-garage-door-rollershutter branch August 1, 2024 13:08
digitaldan pushed a commit to digitaldan/openhab-addons that referenced this pull request Aug 29, 2024
pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 29, 2024
…penhab#17150)

Signed-off-by: Cody Cutrer <cody@cutrer.us>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants