Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[shelly] Add support for various Gen3 devices (Plus 1/1PM, Mini 1/PM/1PM, Dimmer 0110, i4) #17166

Merged
merged 4 commits into from
Aug 4, 2024

Conversation

markus7017
Copy link
Contributor

@markus7017 markus7017 commented Jul 27, 2024

This PR adds

Shelly Plus 1 Gen3
Shelly Plus 1PM Gen3
Shelly Plus Mini 1 Gen3
Shelly Plus Mini PM Gen3
Shelly Plus Mini 1PM Gen3
Shelly Plus Dimmer 0110 Gen3
Shelly Plus i4 Gen3

Closing
#16773

@markus7017 markus7017 added enhancement An enhancement or new feature for an existing add-on awaiting other PR Depends on another PR labels Jul 27, 2024
@markus7017 markus7017 self-assigned this Jul 27, 2024
@markus7017 markus7017 removed the awaiting other PR Depends on another PR label Jul 27, 2024
@markus7017 markus7017 requested a review from lsiepel July 27, 2024 19:53
@markus7017 markus7017 changed the title [shelly][WIP] Support for various Gen3 devices (Plus 1/1PM, Mini 1/PM/1PM, Dimmer 0110, i4) [shelly] Support for various Gen3 devices (Plus 1/1PM, Mini 1/PM/1PM, Dimmer 0110, i4) Jul 27, 2024
@markus7017 markus7017 linked an issue Jul 27, 2024 that may be closed by this pull request
@jlaur jlaur assigned jlaur and unassigned markus7017 Jul 28, 2024
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding support for more devices! I have added a few questions and comments for consideration (nothing that blocks the PR).

@jlaur jlaur removed their assignment Jul 28, 2024
@jlaur jlaur changed the title [shelly] Support for various Gen3 devices (Plus 1/1PM, Mini 1/PM/1PM, Dimmer 0110, i4) [shelly] Add support for various Gen3 devices (Plus 1/1PM, Mini 1/PM/1PM, Dimmer 0110, i4) Jul 28, 2024
@markus7017
Copy link
Contributor Author

@jlaur review changes are applied

@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/shelly-binding/56862/3999

@jlaur jlaur added the awaiting other PR Depends on another PR label Jul 30, 2024
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/shelly-binding/56862/4003

@jlaur jlaur removed the awaiting other PR Depends on another PR label Aug 2, 2024
@jlaur
Copy link
Contributor

jlaur commented Aug 2, 2024

@markus7017 - can you rebase?

@markus7017
Copy link
Contributor Author

I'm traveling, do so soon

Signed-off-by: Markus Michels <markus7017@gmail.com>
Signed-off-by: Markus Michels <markus7017@gmail.com>
Signed-off-by: Markus Michels <markus7017@gmail.com>
SHELLYDT_PLUS1G3 added
@markus7017
Copy link
Contributor Author

@jlaur done, ready to merge

Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlaur jlaur merged commit fe0b1f8 into openhab:main Aug 4, 2024
5 checks passed
@jlaur jlaur added this to the 4.3 milestone Aug 4, 2024
digitaldan pushed a commit to digitaldan/openhab-addons that referenced this pull request Aug 29, 2024
…1PM, Dimmer 0110, i4) (openhab#17166)

Signed-off-by: Markus Michels <markus7017@gmail.com>
pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 29, 2024
…1PM, Dimmer 0110, i4) (openhab#17166)

Signed-off-by: Markus Michels <markus7017@gmail.com>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
…1PM, Dimmer 0110, i4) (openhab#17166)

Signed-off-by: Markus Michels <markus7017@gmail.com>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
…1PM, Dimmer 0110, i4) (openhab#17166)

Signed-off-by: Markus Michels <markus7017@gmail.com>
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/4-2m4-shelly-wave-1pm-mini-and-i4-not-recognized/160259/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Shelly] New Device Mini 1 Gen 3
3 participants