-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[shelly] Add support for various Gen3 devices (Plus 1/1PM, Mini 1/PM/1PM, Dimmer 0110, i4) #17166
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding support for more devices! I have added a few questions and comments for consideration (nothing that blocks the PR).
...g.shelly/src/main/java/org/openhab/binding/shelly/internal/discovery/ShellyThingCreator.java
Show resolved
Hide resolved
...g.shelly/src/main/java/org/openhab/binding/shelly/internal/discovery/ShellyThingCreator.java
Show resolved
Hide resolved
...inding.shelly/src/main/java/org/openhab/binding/shelly/internal/api/ShellyDeviceProfile.java
Show resolved
Hide resolved
...inding.shelly/src/main/java/org/openhab/binding/shelly/internal/api/ShellyDeviceProfile.java
Outdated
Show resolved
Hide resolved
...hab.binding.shelly/src/main/java/org/openhab/binding/shelly/internal/api2/Shelly2ApiRpc.java
Outdated
Show resolved
Hide resolved
...inding.shelly/src/main/java/org/openhab/binding/shelly/internal/api/ShellyDeviceProfile.java
Outdated
Show resolved
Hide resolved
...nding.shelly/src/main/java/org/openhab/binding/shelly/internal/handler/ShellyComponents.java
Show resolved
Hide resolved
...ding.shelly/src/main/java/org/openhab/binding/shelly/internal/handler/ShellyBaseHandler.java
Show resolved
Hide resolved
@jlaur review changes are applied |
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
@markus7017 - can you rebase? |
I'm traveling, do so soon |
Signed-off-by: Markus Michels <markus7017@gmail.com>
Signed-off-by: Markus Michels <markus7017@gmail.com>
Signed-off-by: Markus Michels <markus7017@gmail.com>
SHELLYDT_PLUS1G3 added
c514e95
to
df4801d
Compare
@jlaur done, ready to merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…1PM, Dimmer 0110, i4) (openhab#17166) Signed-off-by: Markus Michels <markus7017@gmail.com>
…1PM, Dimmer 0110, i4) (openhab#17166) Signed-off-by: Markus Michels <markus7017@gmail.com> Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
…1PM, Dimmer 0110, i4) (openhab#17166) Signed-off-by: Markus Michels <markus7017@gmail.com>
…1PM, Dimmer 0110, i4) (openhab#17166) Signed-off-by: Markus Michels <markus7017@gmail.com>
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/4-2m4-shelly-wave-1pm-mini-and-i4-not-recognized/160259/1 |
This PR adds
Shelly Plus 1 Gen3
Shelly Plus 1PM Gen3
Shelly Plus Mini 1 Gen3
Shelly Plus Mini PM Gen3
Shelly Plus Mini 1PM Gen3
Shelly Plus Dimmer 0110 Gen3
Shelly Plus i4 Gen3
Closing
#16773