[shelly] Fix BLU Discovery when Shelly Cloud Bluetooth Gateway is enabled #17167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this case the binding's gateway script could not get access to the BLE observer). Signed-off-by: Markus Michels <markus7017@gmail.com>
markus7017
added
enhancement
|
@markus7017 - the label "awaiting feedback" is set when awaiting feedback from the contributor. When set, it signals low-priority and likely won't be picked up for a review. If you are waiting for user feedback, you could instead use the label "additional testing preferred". And to block the PR from being merged, you can mark it as a draft (and optionally add label "work in progress" for better visibility). |
markus7017
removed
the
awaiting feedback
|
ok, good to know |
|
@jlaur it's ready to merge |
markus7017
changed the title
|
Please consider to also merge into 4.2 |
jlaur
added
bug
jlaur
changed the title
jlaur
pushed a commit
that referenced
this pull request
Jul 30, 2024
#17167) this case the binding's gateway script could not get access to the BLE observer). Signed-off-by: Markus Michels <markus7017@gmail.com>
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
digitaldan
pushed a commit
to digitaldan/openhab-addons
that referenced
this pull request
Aug 29, 2024
openhab#17167) this case the binding's gateway script could not get access to the BLE observer). Signed-off-by: Markus Michels <markus7017@gmail.com>
pgfeller
pushed a commit
to pgfeller/openhab-addons
that referenced
this pull request
Sep 29, 2024
openhab#17167) this case the binding's gateway script could not get access to the BLE observer). Signed-off-by: Markus Michels <markus7017@gmail.com> Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993
pushed a commit
to joni1993/openhab-addons
that referenced
this pull request
Oct 15, 2024
openhab#17167) this case the binding's gateway script could not get access to the BLE observer). Signed-off-by: Markus Michels <markus7017@gmail.com>
matchews
pushed a commit
to matchews/openhab-addons
that referenced
this pull request
Oct 18, 2024
openhab#17167) this case the binding's gateway script could not get access to the BLE observer). Signed-off-by: Markus Michels <markus7017@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The binding's gateway script could not get access to the BLE observer in case the Shelly Cloud Bluetooth Gateway is enabled. Therefore no discovery results will be passed to openHAB.
The binding now checks the device settings and adjust them if nessecary.