Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fronius] Add battery control Thing actions #17170

Merged
merged 11 commits into from
Jul 30, 2024

Conversation

florian-h05
Copy link
Contributor

This adds several Thing actions for the powerinverter Thing that allow to control the battery charging and discharging behaviour of Fronius hybrid inverters by setting time of use plans.

Battery control is done by configuring time of use plans in the inverter's battery management settings and therefore not compatible with user-specified time of use plans (it overrides them).

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 requested a review from trokohl as a code owner July 28, 2024 13:59
@florian-h05 florian-h05 requested review from jimtng and a team July 28, 2024 14:00
@florian-h05 florian-h05 added the enhancement An enhancement or new feature for an existing add-on label Jul 28, 2024
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments and question. Otherwise LGTM

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05
Copy link
Contributor Author

@lsiepel Thanks for your quick review - I have addressed your comments and answered your question 👍

@florian-h05 florian-h05 requested a review from lsiepel July 29, 2024 22:44
@lsiepel lsiepel merged commit bfce4b2 into openhab:main Jul 30, 2024
5 checks passed
@lsiepel lsiepel added this to the 4.3 milestone Jul 30, 2024
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@florian-h05 florian-h05 deleted the fronius-batterycontrol branch July 30, 2024 07:07
digitaldan pushed a commit to digitaldan/openhab-addons that referenced this pull request Aug 29, 2024
* [fronius] Add DTOs for /config/timeofuse HTTP endpoint

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 29, 2024
* [fronius] Add DTOs for /config/timeofuse HTTP endpoint

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
* [fronius] Add DTOs for /config/timeofuse HTTP endpoint

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
* [fronius] Add DTOs for /config/timeofuse HTTP endpoint

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants