[jsscripting] Fix console logger name & timer identifier missing for UI scripts #17171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes openhab#17165. Caused by openhab/openhab-core#4289. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
florian-h05
added
the
bug
…al for UI scripts Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
florian-h05
changed the title
florian-h05
changed the title
|
@digitaldan Can you please take a look at this PR? It’s only JS changes to the globals injection script. |
jlaur
added
the
regression
digitaldan
pushed a commit
to digitaldan/openhab-addons
that referenced
this pull request
Aug 29, 2024
…UI scripts (openhab#17171) * [jsscripting] Fix console logger name is missing for UI scripts * [jsscripting] Fix timer identifier "missing" for setTimeout/setInterval for UI scripts Fixes openhab#17165. Caused by openhab/openhab-core#4289. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
pgfeller
pushed a commit
to pgfeller/openhab-addons
that referenced
this pull request
Sep 29, 2024
…UI scripts (openhab#17171) * [jsscripting] Fix console logger name is missing for UI scripts * [jsscripting] Fix timer identifier "missing" for setTimeout/setInterval for UI scripts Fixes openhab#17165. Caused by openhab/openhab-core#4289. Signed-off-by: Florian Hotze <florianh_dev@icloud.com> Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993
pushed a commit
to joni1993/openhab-addons
that referenced
this pull request
Oct 15, 2024
…UI scripts (openhab#17171) * [jsscripting] Fix console logger name is missing for UI scripts * [jsscripting] Fix timer identifier "missing" for setTimeout/setInterval for UI scripts Fixes openhab#17165. Caused by openhab/openhab-core#4289. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
matchews
pushed a commit
to matchews/openhab-addons
that referenced
this pull request
Oct 18, 2024
…UI scripts (openhab#17171) * [jsscripting] Fix console logger name is missing for UI scripts * [jsscripting] Fix timer identifier "missing" for setTimeout/setInterval for UI scripts Fixes openhab#17165. Caused by openhab/openhab-core#4289. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17165.
Caused by openhab/openhab-core#4289.