[freeboxos] Enhance log warning when handling channel command fails #17201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lolodomo
added
the
enhancement
clinique
approved these changes
Aug 3, 2024
|
I will try to also log what permission is missing. |
lolodomo
force-pushed
the
freeboxos_log_handling_cmd
branch
from
0a219db
to
31803c0
Compare
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
lolodomo
force-pushed
the
freeboxos_log_handling_cmd
branch
from
31803c0
to
2941341
Compare
|
Ready again for review. |
lolodomo
added
rebuild
|
I will rather use the error code to trigger PermissionException. |
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
|
@clinique : last change applied |
clinique
approved these changes
Aug 4, 2024
jlaur
added
rebuild
digitaldan
pushed a commit
to digitaldan/openhab-addons
that referenced
this pull request
Aug 29, 2024
…penhab#17201) * Throw PermissionException based on error code Signed-off-by: Laurent Garnier <lg.hc@free.fr>
pgfeller
pushed a commit
to pgfeller/openhab-addons
that referenced
this pull request
Sep 29, 2024
…penhab#17201) * Throw PermissionException based on error code Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993
pushed a commit
to joni1993/openhab-addons
that referenced
this pull request
Oct 15, 2024
…penhab#17201) * Throw PermissionException based on error code Signed-off-by: Laurent Garnier <lg.hc@free.fr>
matchews
pushed a commit
to matchews/openhab-addons
that referenced
this pull request
Oct 18, 2024
…penhab#17201) * Throw PermissionException based on error code Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Laurent Garnier lg.hc@free.fr