Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[freeboxos] Remove veto policy on key-code channel #17224

Merged
merged 1 commit into from
Aug 11, 2024

Conversation

lolodomo
Copy link
Contributor

This allows to have as status the last command sent.

Also fix a typo in a log and enhance the check of the remoteCode parameter.

Signed-off-by: Laurent Garnier lg.hc@free.fr

This allows to have as status the last command sent.

Also fix a typo in a log and enhance the check of the remoteCode parameter.

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo lolodomo added the enhancement An enhancement or new feature for an existing add-on label Aug 10, 2024
@lolodomo lolodomo requested a review from clinique as a code owner August 10, 2024 16:33
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Will wait for @clinique to confirm.

@lolodomo lolodomo added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Aug 10, 2024
Copy link
Contributor

@clinique clinique left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lsiepel lsiepel merged commit 9b9cdd5 into openhab:main Aug 11, 2024
5 checks passed
@lsiepel lsiepel added this to the 4.3 milestone Aug 11, 2024
@lolodomo lolodomo deleted the freeboxos_fix_check_remoteCode branch August 11, 2024 07:38
digitaldan pushed a commit to digitaldan/openhab-addons that referenced this pull request Aug 29, 2024
This allows to have as status the last command sent.

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 29, 2024
This allows to have as status the last command sent.

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
This allows to have as status the last command sent.

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
This allows to have as status the last command sent.

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
chilobo pushed a commit to chilobo/openhab-addons that referenced this pull request Nov 20, 2024
This allows to have as status the last command sent.

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Christian Koch <christian@koch-bensheim.de>
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this pull request Jan 2, 2025
This allows to have as status the last command sent.

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants