-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[freeboxos] Remove veto policy on key-code channel #17224
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to have as status the last command sent. Also fix a typo in a log and enhance the check of the remoteCode parameter. Signed-off-by: Laurent Garnier <lg.hc@free.fr>
lolodomo
added
the
enhancement
An enhancement or new feature for an existing add-on
label
Aug 10, 2024
lsiepel
approved these changes
Aug 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Will wait for @clinique to confirm.
lolodomo
added
rebuild
Triggers Jenkins PR build
and removed
rebuild
Triggers Jenkins PR build
labels
Aug 10, 2024
clinique
approved these changes
Aug 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
digitaldan
pushed a commit
to digitaldan/openhab-addons
that referenced
this pull request
Aug 29, 2024
This allows to have as status the last command sent. Signed-off-by: Laurent Garnier <lg.hc@free.fr>
pgfeller
pushed a commit
to pgfeller/openhab-addons
that referenced
this pull request
Sep 29, 2024
This allows to have as status the last command sent. Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993
pushed a commit
to joni1993/openhab-addons
that referenced
this pull request
Oct 15, 2024
This allows to have as status the last command sent. Signed-off-by: Laurent Garnier <lg.hc@free.fr>
matchews
pushed a commit
to matchews/openhab-addons
that referenced
this pull request
Oct 18, 2024
This allows to have as status the last command sent. Signed-off-by: Laurent Garnier <lg.hc@free.fr>
chilobo
pushed a commit
to chilobo/openhab-addons
that referenced
this pull request
Nov 20, 2024
This allows to have as status the last command sent. Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: Christian Koch <christian@koch-bensheim.de>
cipianpascu
pushed a commit
to cipianpascu/openhab-addons
that referenced
this pull request
Jan 2, 2025
This allows to have as status the last command sent. Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to have as status the last command sent.
Also fix a typo in a log and enhance the check of the remoteCode parameter.
Signed-off-by: Laurent Garnier lg.hc@free.fr