Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[openhabcloud] Update Docs : rules and app actions #17234

Merged
merged 4 commits into from
Aug 11, 2024

Conversation

digitaldan
Copy link
Contributor

Adds new 'rule' and 'app' actions to the docs for mobile push notifications
See #16934

Adds new 'rule' and 'app' actions to the docs for mobile push notifications

Signed-off-by: Dan Cunningham <dan@digitaldan.com>
@digitaldan
Copy link
Contributor Author

@mueller-ma ☝️

Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the doc changes, please have a look at my comments:

bundles/org.openhab.io.openhabcloud/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.io.openhabcloud/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.io.openhabcloud/README.md Outdated Show resolved Hide resolved
digitaldan and others added 3 commits August 11, 2024 10:54
Co-authored-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
Co-authored-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
@digitaldan
Copy link
Contributor Author

Thanks @florian-h05 !

Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@lsiepel lsiepel merged commit b002fd7 into openhab:main Aug 11, 2024
5 checks passed
@lsiepel lsiepel added this to the 4.3 milestone Aug 11, 2024
@mueller-ma
Copy link
Member

I'm too late for the party here, so I created #17248. app will only work on the F-Droid build :/

digitaldan added a commit to digitaldan/openhab-addons that referenced this pull request Aug 29, 2024
* [openhabcloud] Update Docs : rules and app actions
Adds new 'rule' and 'app' actions to the docs for mobile push notifications

Signed-off-by: Dan Cunningham <dan@digitaldan.com>
pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 29, 2024
* [openhabcloud] Update Docs : rules and app actions
Adds new 'rule' and 'app' actions to the docs for mobile push notifications

Signed-off-by: Dan Cunningham <dan@digitaldan.com>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
* [openhabcloud] Update Docs : rules and app actions
Adds new 'rule' and 'app' actions to the docs for mobile push notifications

Signed-off-by: Dan Cunningham <dan@digitaldan.com>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
* [openhabcloud] Update Docs : rules and app actions
Adds new 'rule' and 'app' actions to the docs for mobile push notifications

Signed-off-by: Dan Cunningham <dan@digitaldan.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants