[linktap] Initial contribution #17235

dag81 · 2024-08-11T21:38:49Z

[linkTap] Initial code commit.

lsiepel · 2024-08-11T22:06:45Z

Thank you for creating this PR to contribute this binding. As this is still a draft it won’t be reviewed yet, but I had a quick peek and would like to comment upfront.
To manage expectations; review capacity is somewhat limited so don’t expect an immediate full review. To speed up the process you can already perform a self-review by checking this list: https://github.com/openhab/openhab-addons/wiki/Review-Checklist
For example one of the improvements that should be made is to adhere to the naming convention lower-case-hyphen for channel id’s etc. For reference: https://www.openhab.org/docs/developer/guidelines.html#naming-convention

dag81 · 2024-08-11T22:08:12Z

Thank you for creating this PR to contribute this binding. As this is still a draft it won’t be reviewed yet, but I had a quick peek and would like to comment upfront. To manage expectations; review capacity is somewhat limited so don’t expect an immediate full review. To speed up the process you can already perform a self-review by checking this list: https://github.com/openhab/openhab-addons/wiki/Review-Checklist For example one of the improvements that should be made is to adhere to the naming convention lower-case-hyphen for channel id’s etc. For reference: https://www.openhab.org/docs/developer/guidelines.html#naming-convention

Thank you I'll work through it before changing to a non-draft PR to save any time wastage.

[linkTap] Initial code commit. Signed-off-by: dag81 <david.goodyear@gmail.com>

[linkTap] i18 http warning additions Signed-off-by: dag81 <david.goodyear@gmail.com>

lsiepel · 2024-09-28T11:38:41Z

3 comments are left open. Otherwise LGTM

[linkTap] i18 wip upload Signed-off-by: dag81 <david.goodyear@gmail.com>

[linkTap] i18 tns exception Signed-off-by: dag81 <david.goodyear@gmail.com>

[linkTap] i18 again Signed-off-by: dag81 <david.goodyear@gmail.com>

[linkTap] i18 cleanups Signed-off-by: dag81 <david.goodyear@gmail.com>

[linkTap] further i18n Signed-off-by: dag81 <david.goodyear@gmail.com>

[linkTap] i18 cleanups Signed-off-by: dag81 <david.goodyear@gmail.com>

[linkTap] variable sortout Signed-off-by: dag81 <david.goodyear@gmail.com>

dag81 · 2024-09-29T02:08:03Z

Hi @lsiepel, I think hopefully its ready for a final pass fingers crossed. I've been at it for a few hours so I can't spot where to change to awaiting to review - so sorry for the directed message. Hopefully it looks good now,

[linkTap] compiler import warn fixes Signed-off-by: dag81 <david.goodyear@gmail.com>

lsiepel · 2024-09-29T12:07:05Z

Hi @lsiepel, I think hopefully its ready for a final pass fingers crossed. I've been at it for a few hours so I can't spot where to change to awaiting to review - so sorry for the directed message. Hopefully it looks good now,

One comment about the exception is still open. otherwise LGTM. Do you need some adidtional time to test before we merge?

[linkTap] generic exception addition Signed-off-by: dag81 <david.goodyear@gmail.com>

dag81 · 2024-09-29T17:59:57Z

Hi @lsiepel, I think hopefully its ready for a final pass fingers crossed. I've been at it for a few hours so I can't spot where to change to awaiting to review - so sorry for the directed message. Hopefully it looks good now,

One comment about the exception is still open. otherwise LGTM. Do you need some adidtional time to test before we merge?

Hi @lsiepel I'm running the fully adjusted build through the different VM's and computers now, just in case. (Although I've been spot testing, I'll run it through the different scenarios one last time. If I don't reply by tomorrow say 24 hours tomorrow evening UK time, then it should be good to merge. (Sorry I didn't see it :( but glad you brought it to my attention).

dag81 · 2024-09-29T23:58:41Z

Hi @lsiepel, I think hopefully its ready for a final pass fingers crossed. I've been at it for a few hours so I can't spot where to change to awaiting to review - so sorry for the directed message. Hopefully it looks good now,

One comment about the exception is still open. otherwise LGTM. Do you need some adidtional time to test before we merge?

Hi @lsiepel I'm running the fully adjusted build through the different VM's and computers now, just in case. (Although I've been spot testing, I'll run it through the different scenarios one last time. If I don't reply by tomorrow say 24 hours tomorrow evening UK time, then it should be good to merge. (Sorry I didn't see it :( but glad you brought it to my attention).

It all looks good thanks @lsiepel please merge when you can. Thanks again for all the time, and time spent in regards to this and assistance as mentioned before.

lsiepel · 2024-09-30T03:51:41Z

Thanks, now this is merged, you could add your binding's logo to the openHAB website. See https://next.openhab.org/docs/developer/addons/#add-your-add-on-s-logo-to-the-openhab-website-and-the-ui

florian-h05 · 2024-10-01T20:42:46Z

...binding.linktap/src/main/java/org/openhab/binding/linktap/internal/LinkTapBridgeHandler.java

+        final long sysMillis = System.currentTimeMillis();
+        if (lastMdnsScanMillis + MIN_TIME_BETWEEN_MDNS_SCANS_MS < sysMillis) {
+            logger.debug("Requesting MDNS Scan");
+            discoverySrvReg.startScan(THING_TYPE_GATEWAY, null);


This line is making CI fail, see for example https://ci.openhab.org/job/openHAB-Addons/1530/org.openhab.addons.bundles$org.openhab.binding.linktap/console.

@openhab/add-ons-maintainers Can you please take care?

* [linkTap] Initial Code Commit [Signed-off-by: dag81 <david.goodyear@gmail.com>

jlaur · 2024-11-29T08:46:11Z

@dag81, @lsiepel - the sign-off here violated our policy regarding real name: https://www.openhab.org/docs/developer/contributing.html#sign-your-work

@dag81 - can you fix your sign-off for future PR's? Thanks.

dag81 · 2024-11-29T08:59:12Z

@dag81, @lsiepel - the sign-off here violated our policy regarding real name: https://www.openhab.org/docs/developer/contributing.html#sign-your-work

@dag81 - can you fix your sign-off for future PR's? Thanks.

Hi @jlaur,

You mean change it to:

[binding] XYZ

Signed-off-by: David Goodyear david.goodyear@gmail.com

Correct?

(I think I tried that and the DCO check failed which is why I switched to the one that worked historically - I can try the above again on the next push to the last open PR - to see if it passes). - I just added my name to the GitHub repo as David Goodyear - so that may have been what prevented it before? (I haven't looked at your GitHub action pipeline but that's my best guess where its cross checking against?)

jlaur · 2024-11-29T09:10:32Z

You mean change it to:

[binding] XYZ

Signed-off-by: David Goodyear david.goodyear@gmail.com

Correct?

Yes, to be accurate:

Signed-off-by: David Goodyear <david.goodyear@gmail.com>

I believe the DCO passes when the commit sign-off matches your GitHub account, so I'm not sure why you had a DCO failure, but we could look into that on your next PR. 🙂

lsiepel · 2024-11-29T10:06:39Z

Ah missed that one. We are working on another PR. So let’s see if we can fix the DCO there. @dag81

dag81 force-pushed the bindinngs/linkTap branch from 84f25c8 to 7777df1 Compare August 11, 2024 21:47

lsiepel added the new binding If someone has started to work on a binding. For a new binding PR. label Aug 11, 2024

dag81 force-pushed the bindinngs/linkTap branch 2 times, most recently from 24e1a13 to e8799ee Compare August 11, 2024 22:06

dag81 force-pushed the bindinngs/linkTap branch 2 times, most recently from a3e33b3 to 8c3cc6c Compare August 11, 2024 23:03

[linkTap] Initial Code Commit

4e810ea

[linkTap] Initial code commit. Signed-off-by: dag81 <david.goodyear@gmail.com>

dag81 force-pushed the bindinngs/linkTap branch from 8c3cc6c to 4e810ea Compare August 11, 2024 23:07

dag81 added 2 commits August 12, 2024 22:41

[linkTap] Initial Code Commit

2b5215b

[linkTap] Initial code commit. Signed-off-by: dag81 <david.goodyear@gmail.com>

[linkTap] Rebased to main

1729cf3

[linkTap] Initial code commit. Signed-off-by: dag81 <david.goodyear@gmail.com>

dag81 force-pushed the bindinngs/linkTap branch from 9298bbf to 1729cf3 Compare August 12, 2024 21:03

[linkTap] Initial code commit.

727756f

[linkTap] Initial code commit. Signed-off-by: dag81 <david.goodyear@gmail.com>

dag81 force-pushed the bindinngs/linkTap branch from 18bc9e5 to 727756f Compare August 13, 2024 13:43

Merge branch 'openhab:main' into bindinngs/linkTap

0c404fd

dag81 force-pushed the bindinngs/linkTap branch 5 times, most recently from b97f678 to 3079be4 Compare August 19, 2024 13:43

lsiepel changed the title ~~[linkTap] Initial Code Commit~~ [linktap] Initial contribution Aug 19, 2024

dag81 force-pushed the bindinngs/linkTap branch 8 times, most recently from 3709a3f to b7c26bc Compare August 20, 2024 20:34

dag81 added 3 commits September 25, 2024 00:17

[linkTap] i18 http warning additions

a688dca

[linkTap] i18 http warning additions Signed-off-by: dag81 <david.goodyear@gmail.com>

[linkTap] i18 http warning additions

e15b9bb

[linkTap] i18 http warning additions Signed-off-by: dag81 <david.goodyear@gmail.com>

[linkTap] i18 http warning additions

ee0225b

[linkTap] i18 http warning additions Signed-off-by: dag81 <david.goodyear@gmail.com>

dag81 added 7 commits September 28, 2024 15:09

[linkTap] i18 wip upload

1369384

[linkTap] i18 wip upload Signed-off-by: dag81 <david.goodyear@gmail.com>

[linkTap] i18 tns exception

fae4e2b

[linkTap] i18 tns exception Signed-off-by: dag81 <david.goodyear@gmail.com>

[linkTap] i18 again

db14b14

[linkTap] i18 again Signed-off-by: dag81 <david.goodyear@gmail.com>

[linkTap] i18 cleanups

79e2d53

[linkTap] i18 cleanups Signed-off-by: dag81 <david.goodyear@gmail.com>

[linkTap] further i18n

c2ea4ed

[linkTap] further i18n Signed-off-by: dag81 <david.goodyear@gmail.com>

[linkTap] i18 cleanups

ac396bc

[linkTap] i18 cleanups Signed-off-by: dag81 <david.goodyear@gmail.com>

[linkTap] variable sortout

f7e46bf

[linkTap] variable sortout Signed-off-by: dag81 <david.goodyear@gmail.com>

[linkTap] compiler import warn fixes

1420f3a

[linkTap] compiler import warn fixes Signed-off-by: dag81 <david.goodyear@gmail.com>

[linkTap] generic exception addition

eb462ea

[linkTap] generic exception addition Signed-off-by: dag81 <david.goodyear@gmail.com>

lsiepel approved these changes Sep 29, 2024

View reviewed changes

lsiepel merged commit b11c751 into openhab:main Sep 30, 2024
5 checks passed

lsiepel added this to the 4.3 milestone Sep 30, 2024

dag81 mentioned this pull request Sep 30, 2024

[linktap] Addition of logo openhab/openhab-docs#2378

Merged

florian-h05 reviewed Oct 1, 2024

View reviewed changes

jlaur mentioned this pull request Oct 1, 2024

[linktap] Fix build #17493

Merged

joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024

[linktap] Initial contribution (openhab#17235)

02a987c

* [linkTap] Initial Code Commit [Signed-off-by: dag81 <david.goodyear@gmail.com>

matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024

[linktap] Initial contribution (openhab#17235)

795d99e

* [linkTap] Initial Code Commit [Signed-off-by: dag81 <david.goodyear@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[linktap] Initial contribution #17235

[linktap] Initial contribution #17235

dag81 commented Aug 11, 2024

lsiepel commented Aug 11, 2024

dag81 commented Aug 11, 2024

lsiepel commented Sep 28, 2024

dag81 commented Sep 29, 2024

lsiepel commented Sep 29, 2024

dag81 commented Sep 29, 2024 •

edited

Loading

dag81 commented Sep 29, 2024

lsiepel commented Sep 30, 2024

florian-h05 Oct 1, 2024

jlaur Oct 1, 2024

jlaur commented Nov 29, 2024

dag81 commented Nov 29, 2024 •

edited

Loading

jlaur commented Nov 29, 2024

lsiepel commented Nov 29, 2024

[linktap] Initial contribution #17235

[linktap] Initial contribution #17235

Conversation

dag81 commented Aug 11, 2024

lsiepel commented Aug 11, 2024

dag81 commented Aug 11, 2024

lsiepel commented Sep 28, 2024

dag81 commented Sep 29, 2024

lsiepel commented Sep 29, 2024

dag81 commented Sep 29, 2024 • edited Loading

dag81 commented Sep 29, 2024

lsiepel commented Sep 30, 2024

florian-h05 Oct 1, 2024

Choose a reason for hiding this comment

jlaur Oct 1, 2024

Choose a reason for hiding this comment

jlaur commented Nov 29, 2024

dag81 commented Nov 29, 2024 • edited Loading

jlaur commented Nov 29, 2024

lsiepel commented Nov 29, 2024

dag81 commented Sep 29, 2024 •

edited

Loading

dag81 commented Nov 29, 2024 •

edited

Loading