[freeboxos] Avoid useless API requests (server/player) #17237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids API requests when channels are unlinked. Signed-off-by: Laurent Garnier <lg.hc@free.fr>
lolodomo
added
the
enhancement
|
Let me know the outcome of this in term of requests decrease. |
For the Revolution server, it can be 9 calls less, depending on what channels are linked. The minimum number of calls is now one call, the max is 10 calls. If all non advanced channels are linked, this will be 5 calls now, instead of 10 calls before. So a gain of 50%. For the (active) player, it is just one call less, depending on what channels are linked. The minimum number of calls is now 2 calls, the max is 3 calls.
No |
jlaur
reviewed
Aug 12, 2024
...eboxos/src/main/java/org/openhab/binding/freeboxos/internal/handler/ActivePlayerHandler.java
Outdated
Show resolved
Hide resolved
...eboxos/src/main/java/org/openhab/binding/freeboxos/internal/handler/ActivePlayerHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
clinique
requested changes
Aug 13, 2024
...reeboxos/src/main/java/org/openhab/binding/freeboxos/internal/handler/RevolutionHandler.java
Outdated
Show resolved
Hide resolved
jlaur
changed the title
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
clinique
approved these changes
Aug 13, 2024
|
Thank you @jlaur |
digitaldan
pushed a commit
to digitaldan/openhab-addons
that referenced
this pull request
Aug 29, 2024
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
pgfeller
pushed a commit
to pgfeller/openhab-addons
that referenced
this pull request
Sep 29, 2024
Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993
pushed a commit
to joni1993/openhab-addons
that referenced
this pull request
Oct 15, 2024
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
matchews
pushed a commit
to matchews/openhab-addons
that referenced
this pull request
Oct 18, 2024
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
chilobo
pushed a commit
to chilobo/openhab-addons
that referenced
this pull request
Nov 20, 2024
Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: Christian Koch <christian@koch-bensheim.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids API requests when channels are unlinked.
Signed-off-by: Laurent Garnier lg.hc@free.fr