Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wled] Fix: FX and Palettes channel StateDescriptionProvider handling #17277

Merged
merged 2 commits into from
Aug 18, 2024

Conversation

t2000
Copy link
Contributor

@t2000 t2000 commented Aug 17, 2024

Fixes #17276

@t2000 t2000 requested a review from Skinah as a code owner August 17, 2024 14:02
@t2000
Copy link
Contributor Author

t2000 commented Aug 17, 2024

PS: It would also be nice to see some progress on #16907

Its not really motivating (although I understand that it is summer holiday season) to see small bugfixes hanging around for 2 months :-(

@lsiepel
Copy link
Contributor

lsiepel commented Aug 17, 2024

PS: It would also be nice to see some progress on #16907

Its not really motivating (although I understand that it is summer holiday season) to see small bugfixes hanging around for 2 months :-(

That PR was merged now. We prefer to wait for codeowners to comment, but unfortunately many are time constrained. Thank you for your contribution. If you have a good understanding of the binding you can always apply as codeowner.

Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo
Copy link
Contributor

Build failed, please check the log output.

@lolodomo lolodomo added the bug An unexpected problem or unintended behavior of an add-on label Aug 17, 2024
t2000 added 2 commits August 18, 2024 13:28
Fixes openhab#17276

Signed-off-by: Stefan Triller <github@stefantriller.de>
Signed-off-by: Stefan Triller <github@stefantriller.de>
@t2000 t2000 force-pushed the wledStateDescriptionProviders branch from 4898dae to 85fee79 Compare August 18, 2024 11:31
@lolodomo lolodomo merged commit d158209 into openhab:main Aug 18, 2024
5 checks passed
@lolodomo lolodomo added this to the 4.3 milestone Aug 18, 2024
@t2000 t2000 deleted the wledStateDescriptionProviders branch August 18, 2024 15:58
digitaldan pushed a commit to digitaldan/openhab-addons that referenced this pull request Aug 29, 2024
…openhab#17277)

* [wled] Fix: FX and Palettes channel StateDescriptionProvider handling

Fixes openhab#17276

Signed-off-by: Stefan Triller <github@stefantriller.de>
pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 29, 2024
…openhab#17277)

* [wled] Fix: FX and Palettes channel StateDescriptionProvider handling

Fixes openhab#17276

Signed-off-by: Stefan Triller <github@stefantriller.de>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
…openhab#17277)

* [wled] Fix: FX and Palettes channel StateDescriptionProvider handling

Fixes openhab#17276

Signed-off-by: Stefan Triller <github@stefantriller.de>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
…openhab#17277)

* [wled] Fix: FX and Palettes channel StateDescriptionProvider handling

Fixes openhab#17276

Signed-off-by: Stefan Triller <github@stefantriller.de>
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this pull request Jan 2, 2025
…openhab#17277)

* [wled] Fix: FX and Palettes channel StateDescriptionProvider handling

Fixes openhab#17276

Signed-off-by: Stefan Triller <github@stefantriller.de>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[wled] FX and Palettes channel StateDescriptionProviders not always updated
3 participants