-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wled] Fix: FX and Palettes channel StateDescriptionProvider handling #17277
Conversation
PS: It would also be nice to see some progress on #16907 Its not really motivating (although I understand that it is summer holiday season) to see small bugfixes hanging around for 2 months :-( |
That PR was merged now. We prefer to wait for codeowners to comment, but unfortunately many are time constrained. Thank you for your contribution. If you have a good understanding of the binding you can always apply as codeowner. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you
Build failed, please check the log output. |
...inding.wled/src/main/java/org/openhab/binding/wled/internal/handlers/WLedSegmentHandler.java
Outdated
Show resolved
Hide resolved
...inding.wled/src/main/java/org/openhab/binding/wled/internal/handlers/WLedSegmentHandler.java
Outdated
Show resolved
Hide resolved
Fixes openhab#17276 Signed-off-by: Stefan Triller <github@stefantriller.de>
Signed-off-by: Stefan Triller <github@stefantriller.de>
4898dae
to
85fee79
Compare
…openhab#17277) * [wled] Fix: FX and Palettes channel StateDescriptionProvider handling Fixes openhab#17276 Signed-off-by: Stefan Triller <github@stefantriller.de>
…openhab#17277) * [wled] Fix: FX and Palettes channel StateDescriptionProvider handling Fixes openhab#17276 Signed-off-by: Stefan Triller <github@stefantriller.de> Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
…openhab#17277) * [wled] Fix: FX and Palettes channel StateDescriptionProvider handling Fixes openhab#17276 Signed-off-by: Stefan Triller <github@stefantriller.de>
…openhab#17277) * [wled] Fix: FX and Palettes channel StateDescriptionProvider handling Fixes openhab#17276 Signed-off-by: Stefan Triller <github@stefantriller.de>
…openhab#17277) * [wled] Fix: FX and Palettes channel StateDescriptionProvider handling Fixes openhab#17276 Signed-off-by: Stefan Triller <github@stefantriller.de> Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Fixes #17276